c7c645db2f
* Formatting follow-up - Adds formatting commits to .git-blame-ignore-revs so that they don't distract during Git blame - Restores hard line breaks in Troubleshooting.md using `\` instead of trailing spaces - Changes formatting of some string literals and comments - Fixes accidental Javadoc and comment issues introduced by manual changes of formatting commit - Fixes license header in $Gson$Types.java erroneously being a Javadoc comment and being reformatted - Slightly changes `JsonReader` `getPath` and `getPreviousPath` documentation to help Javadoc detect first sentence as summary * Remove `spotless:off` markers * Add empty line before comment * Check format for .github YAML files
2.0 KiB
2.0 KiB
Purpose
Description
Checklist
- New code follows the Google Java Style Guide
This is automatically checked bymvn verify
, but can also be checked on its own usingmvn spotless:check
.
Style violations can be fixed usingmvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes. - If necessary, new public API validates arguments, for example rejects
null
- New public API has Javadoc
- Javadoc uses
@since $next-version$
($next-version$
is a special placeholder which is automatically replaced during release)
- Javadoc uses
- If necessary, new unit tests have been added
- Assertions in unit tests use Truth, see existing tests
- No JUnit 3 features are used (such as extending class
TestCase
) - If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
mvn clean verify javadoc:jar
passes without errors