dc20b7561a
* Adds `@SuppressWarnings("NarrowingCompoundAssignment")`
* Adds `@SuppressWarnings("TypeParameterUnusedInFormals")`
* Adds `@SuppressWarnings("JavaUtilDate")`
* Adds a limit to `String.split()`
* Add `error_prone_annotations` to the `pom.xml`
* Adds `@InlineMe(...)` to deprecated methods
* Adds `@SuppressWarnings("ImmutableEnumChecker")`
* Adds `@SuppressWarnings("ModifiedButNotUsed")`
* Adds `@SuppressWarnings("MixedMutabilityReturnType")`
* Removes an unused import
* Adds `requires` to `module-info.java`
* Adds ErrorProne `link` into `pom.xml`
* Remove unused imports
Removed from:
- ParseBenchmark
* Adds `@SuppressWarnings("EqualsGetClass")`
* Excludes from `proto` just the generated code.
Replaces `.*proto.*` with `.*/generated-test-sources/protobuf/.*` in such way will be excluded just the generated code and not the whole `proto` directory
* Removes an unused variable
Removes the `descriptor` variable because is unused.
* Fixes the `BadImport` warn into `ProtosWithAnnotationsTest`
* Fixes the `BadImport` warns into `ProtosWithAnnotationsTest`
* Enables ErrorProne in `gson/src/test.*`
Removes the `gson/src/test.*` path from the `-XepExcludedPaths` parameter of the ErrorProne plugin
* Fixes `UnusedVariable` warns
This commit fix all `UnusedVariable` warns given by ErrorProne in the `gson/src/test.*` path.
Some field is annotated with `@Keep` that means is used by reflection.
In some other case the record is annotated with `@SuppressWarnings("unused")`
* Fixes `JavaUtilDate` warns
This commit fix all `JavaUtilDate` warns given by ErrorProne in the `gson/src/test.*` path.
Classes/Methods are annotated with `@SuppressWarnings("JavaUtilDate")` because it's not possible use differente Date API.
* Fixes `EqualsGetClass` warns
This commit fix all `EqualsGetClass` warns given by ErrorProne in the `gson/src/test.*` path.
I have rewrite the `equals()` methods to use `instanceof`
* Replaces pattern matching for instanceof with casts
* Fixes `JdkObsolete` warns
This commit fix all `JdkObsolete` warns given by ErrorProne in the `gson/src/test.*` path.
In some cases I have replaced the obsolete JDK classes with the newest alternatives. In other cases, I have added the `@SuppressWarnings("JdkObsolete")`
* Fixes `ClassCanBeStatic` warns
This commit fix all `ClassCanBeStatic` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `static` keyword, or I have added `@SuppressWarnings("ClassCanBeStatic")`
* Fixes `UndefinedEquals` warns
This commit fix all `UndefinedEquals` warns given by ErrorProne in the `gson/src/test.*` path.
I have added `@SuppressWarnings("UndefinedEquals")` or fixed the asserts
Note: In this commit I have also renamed a test from `testRawCollectionDeserializationNotAlllowed` to `testRawCollectionDeserializationNotAllowed`
* Fixes `GetClassOnEnum` warns
This commit fix all `GetClassOnEnum` warns given by ErrorProne in the `gson/src/test.*` path.
I have replaced the `.getClass()` with `.getDeclaringClass()`
* Fixes `ImmutableEnumChecker` warns
This commit fix all `ImmutableEnumChecker` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `final` keyword, or I have added the `@SuppressWarnings("ImmutableEnumChecker")` annotation
* Fixes `StaticAssignmentOfThrowable` warns
This commit fix all `StaticAssignmentOfThrowable` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `AssertionFailureIgnored` warns
This commit fix all `AssertionFailureIgnored` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `@SuppressWarnings("AssertionFailureIgnored")` annotation
* Fixes `ModifiedButNotUsed` warns
This commit fix all `ModifiedButNotUsed` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `@SuppressWarnings("ModifiedButNotUsed")` annotation
* Fixes `MissingSummary` warns
This commit fix all `MissingSummary` warns given by ErrorProne in the `gson/src/test.*` path.
I have remove the Javadoc `@author`
* Fixes `FloatingPointLiteralPrecision` warns
This commit fix all `FloatingPointLiteralPrecision` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `@SuppressWarnings("FloatingPointLiteralPrecision")` annotation
* Fixes `StringSplitter` warns
This commit fix all `StringSplitter` warns given by ErrorProne in the `gson/src/test.*` path.
I have replaced the `String.split(...)` with `Splitter`
* Fixes `EmptyCatch` warns
This commit fix all `EmptyCatch` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `UnicodeEscape` warns
This commit fix all `UnicodeEscape` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `EmptyBlockTag` warns
This commit fix all `EmptyBlockTag` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `LongFloatConversion` warns
This commit fix all `LongFloatConversion` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `LongDoubleConversion` warns
This commit fix all `LongDoubleConversion` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `TruthAssertExpected` warns
This commit fix all `TruthAssertExpected` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `UnusedMethod` warns
This commit fix all `UnusedMethod` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `UnusedTypeParameter` warns
This commit fix all `UnusedTypeParameter` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `CatchFail` warns
This commit fix all `CatchFail` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `MathAbsoluteNegative` warns
This commit fix all `MathAbsoluteNegative` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `LoopOverCharArray` warns
This commit fix all `LoopOverCharArray` warns given by ErrorProne in the `gson/src/test.*` path.
`toCharArray` allocates a new array, using `charAt` is more efficient
* Fixes `HidingField` warns
This commit fix all `HidingField` warns given by ErrorProne in the `gson/src/test.*` path.
* Implements code review feedback
* Implements code review feedback
This commit implements some other code review feedback
* Enable ErrorProne in `extra`
Thi commit removes the `.*extras/src/test.*` path from the `-XepExcludedPaths` parameter of ErrorProne.
* Fix the `JavaUtilDate` warns
This commit fix all `JavaUtilDate` warns given by ErrorProne in the `extras/src/test.*` path.
* Implements code review feedback
* Removes redundant new-line
* Implements code review feedback
* Adds `JDK11` to run test with `--release 11`
* Revert "Adds `JDK11` to run test with `--release 11`"
This reverts commit a7cca386098ae847a10a31c09c3ab9b11eee5920.
241 lines
10 KiB
Java
241 lines
10 KiB
Java
/*
|
|
* Copyright (C) 2008 Google Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.google.gson.internal.bind;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static com.google.common.truth.Truth.assertWithMessage;
|
|
import static org.junit.Assert.fail;
|
|
|
|
import com.google.gson.Gson;
|
|
import com.google.gson.TypeAdapter;
|
|
import com.google.gson.TypeAdapterFactory;
|
|
import com.google.gson.internal.JavaVersion;
|
|
import com.google.gson.internal.bind.DefaultDateTypeAdapter.DateType;
|
|
import com.google.gson.reflect.TypeToken;
|
|
import java.io.IOException;
|
|
import java.text.DateFormat;
|
|
import java.text.SimpleDateFormat;
|
|
import java.util.Date;
|
|
import java.util.Locale;
|
|
import java.util.TimeZone;
|
|
import org.junit.Test;
|
|
|
|
/**
|
|
* A simple unit test for the {@link DefaultDateTypeAdapter} class.
|
|
*
|
|
* @author Joel Leitch
|
|
*/
|
|
@SuppressWarnings("JavaUtilDate")
|
|
public class DefaultDateTypeAdapterTest {
|
|
|
|
@Test
|
|
public void testFormattingInEnUs() {
|
|
assertFormattingAlwaysEmitsUsLocale(Locale.US);
|
|
}
|
|
|
|
@Test
|
|
public void testFormattingInFr() {
|
|
assertFormattingAlwaysEmitsUsLocale(Locale.FRANCE);
|
|
}
|
|
|
|
private void assertFormattingAlwaysEmitsUsLocale(Locale locale) {
|
|
TimeZone defaultTimeZone = TimeZone.getDefault();
|
|
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
|
|
Locale defaultLocale = Locale.getDefault();
|
|
Locale.setDefault(locale);
|
|
try {
|
|
String afterYearSep = JavaVersion.isJava9OrLater() ? ", " : " ";
|
|
String afterYearLongSep = JavaVersion.isJava9OrLater() ? " at " : " ";
|
|
String utcFull = JavaVersion.isJava9OrLater() ? "Coordinated Universal Time" : "UTC";
|
|
assertFormatted(String.format("Jan 1, 1970%s12:00:00 AM", afterYearSep),
|
|
DateType.DATE.createDefaultsAdapterFactory());
|
|
assertFormatted("1/1/70", DateType.DATE.createAdapterFactory(DateFormat.SHORT));
|
|
assertFormatted("Jan 1, 1970", DateType.DATE.createAdapterFactory(DateFormat.MEDIUM));
|
|
assertFormatted("January 1, 1970", DateType.DATE.createAdapterFactory(DateFormat.LONG));
|
|
assertFormatted(String.format("1/1/70%s12:00 AM", afterYearSep),
|
|
DateType.DATE.createAdapterFactory(DateFormat.SHORT, DateFormat.SHORT));
|
|
assertFormatted(String.format("Jan 1, 1970%s12:00:00 AM", afterYearSep),
|
|
DateType.DATE.createAdapterFactory(DateFormat.MEDIUM, DateFormat.MEDIUM));
|
|
assertFormatted(String.format("January 1, 1970%s12:00:00 AM UTC", afterYearLongSep),
|
|
DateType.DATE.createAdapterFactory(DateFormat.LONG, DateFormat.LONG));
|
|
assertFormatted(String.format("Thursday, January 1, 1970%s12:00:00 AM %s", afterYearLongSep, utcFull),
|
|
DateType.DATE.createAdapterFactory(DateFormat.FULL, DateFormat.FULL));
|
|
} finally {
|
|
TimeZone.setDefault(defaultTimeZone);
|
|
Locale.setDefault(defaultLocale);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testParsingDatesFormattedWithSystemLocale() throws Exception {
|
|
TimeZone defaultTimeZone = TimeZone.getDefault();
|
|
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
|
|
Locale defaultLocale = Locale.getDefault();
|
|
Locale.setDefault(Locale.FRANCE);
|
|
try {
|
|
Date date = new Date(0);
|
|
assertParsed(
|
|
DateFormat.getDateTimeInstance(DateFormat.MEDIUM, DateFormat.MEDIUM).format(date),
|
|
DateType.DATE.createDefaultsAdapterFactory());
|
|
assertParsed(
|
|
DateFormat.getDateInstance(DateFormat.SHORT).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.SHORT));
|
|
assertParsed(
|
|
DateFormat.getDateInstance(DateFormat.MEDIUM).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.MEDIUM));
|
|
assertParsed(
|
|
DateFormat.getDateInstance(DateFormat.LONG).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.LONG));
|
|
assertParsed(
|
|
DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.SHORT).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.SHORT, DateFormat.SHORT));
|
|
assertParsed(
|
|
DateFormat.getDateTimeInstance(DateFormat.MEDIUM, DateFormat.MEDIUM).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.MEDIUM, DateFormat.MEDIUM));
|
|
assertParsed(
|
|
DateFormat.getDateTimeInstance(DateFormat.LONG, DateFormat.LONG).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.LONG, DateFormat.LONG));
|
|
assertParsed(
|
|
DateFormat.getDateTimeInstance(DateFormat.FULL, DateFormat.FULL).format(date),
|
|
DateType.DATE.createAdapterFactory(DateFormat.FULL, DateFormat.FULL));
|
|
} finally {
|
|
TimeZone.setDefault(defaultTimeZone);
|
|
Locale.setDefault(defaultLocale);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testParsingDatesFormattedWithUsLocale() throws Exception {
|
|
TimeZone defaultTimeZone = TimeZone.getDefault();
|
|
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
|
|
Locale defaultLocale = Locale.getDefault();
|
|
Locale.setDefault(Locale.US);
|
|
try {
|
|
assertParsed("Jan 1, 1970 0:00:00 AM", DateType.DATE.createDefaultsAdapterFactory());
|
|
assertParsed("1/1/70", DateType.DATE.createAdapterFactory(DateFormat.SHORT));
|
|
assertParsed("Jan 1, 1970", DateType.DATE.createAdapterFactory(DateFormat.MEDIUM));
|
|
assertParsed("January 1, 1970", DateType.DATE.createAdapterFactory(DateFormat.LONG));
|
|
assertParsed("1/1/70 0:00 AM",
|
|
DateType.DATE.createAdapterFactory(DateFormat.SHORT, DateFormat.SHORT));
|
|
assertParsed("Jan 1, 1970 0:00:00 AM",
|
|
DateType.DATE.createAdapterFactory(DateFormat.MEDIUM, DateFormat.MEDIUM));
|
|
assertParsed("January 1, 1970 0:00:00 AM UTC",
|
|
DateType.DATE.createAdapterFactory(DateFormat.LONG, DateFormat.LONG));
|
|
assertParsed("Thursday, January 1, 1970 0:00:00 AM UTC",
|
|
DateType.DATE.createAdapterFactory(DateFormat.FULL, DateFormat.FULL));
|
|
} finally {
|
|
TimeZone.setDefault(defaultTimeZone);
|
|
Locale.setDefault(defaultLocale);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testFormatUsesDefaultTimezone() throws Exception {
|
|
TimeZone defaultTimeZone = TimeZone.getDefault();
|
|
TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"));
|
|
Locale defaultLocale = Locale.getDefault();
|
|
Locale.setDefault(Locale.US);
|
|
try {
|
|
String afterYearSep = JavaVersion.isJava9OrLater() ? ", " : " ";
|
|
assertFormatted(String.format("Dec 31, 1969%s4:00:00 PM", afterYearSep),
|
|
DateType.DATE.createDefaultsAdapterFactory());
|
|
assertParsed("Dec 31, 1969 4:00:00 PM", DateType.DATE.createDefaultsAdapterFactory());
|
|
} finally {
|
|
TimeZone.setDefault(defaultTimeZone);
|
|
Locale.setDefault(defaultLocale);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testDateDeserializationISO8601() throws Exception {
|
|
TypeAdapterFactory adapterFactory = DateType.DATE.createDefaultsAdapterFactory();
|
|
assertParsed("1970-01-01T00:00:00.000Z", adapterFactory);
|
|
assertParsed("1970-01-01T00:00Z", adapterFactory);
|
|
assertParsed("1970-01-01T00:00:00+00:00", adapterFactory);
|
|
assertParsed("1970-01-01T01:00:00+01:00", adapterFactory);
|
|
assertParsed("1970-01-01T01:00:00+01", adapterFactory);
|
|
}
|
|
|
|
@Test
|
|
public void testDateSerialization() {
|
|
int dateStyle = DateFormat.LONG;
|
|
TypeAdapter<Date> dateTypeAdapter = dateAdapter(DateType.DATE.createAdapterFactory(dateStyle));
|
|
DateFormat formatter = DateFormat.getDateInstance(dateStyle, Locale.US);
|
|
Date currentDate = new Date();
|
|
|
|
String dateString = dateTypeAdapter.toJson(currentDate);
|
|
assertThat(dateString).isEqualTo(toLiteral(formatter.format(currentDate)));
|
|
}
|
|
|
|
@Test
|
|
public void testDatePattern() {
|
|
String pattern = "yyyy-MM-dd";
|
|
TypeAdapter<Date> dateTypeAdapter = dateAdapter(DateType.DATE.createAdapterFactory(pattern));
|
|
DateFormat formatter = new SimpleDateFormat(pattern);
|
|
Date currentDate = new Date();
|
|
|
|
String dateString = dateTypeAdapter.toJson(currentDate);
|
|
assertThat(dateString).isEqualTo(toLiteral(formatter.format(currentDate)));
|
|
}
|
|
|
|
@Test
|
|
public void testInvalidDatePattern() {
|
|
try {
|
|
DateType.DATE.createAdapterFactory("I am a bad Date pattern....");
|
|
fail("Invalid date pattern should fail.");
|
|
} catch (IllegalArgumentException expected) { }
|
|
}
|
|
|
|
@Test
|
|
public void testNullValue() throws Exception {
|
|
TypeAdapter<Date> adapter = dateAdapter(DateType.DATE.createDefaultsAdapterFactory());
|
|
assertThat(adapter.fromJson("null")).isNull();
|
|
assertThat(adapter.toJson(null)).isEqualTo("null");
|
|
}
|
|
|
|
@Test
|
|
public void testUnexpectedToken() throws Exception {
|
|
try {
|
|
TypeAdapter<Date> adapter = dateAdapter(DateType.DATE.createDefaultsAdapterFactory());
|
|
adapter.fromJson("{}");
|
|
fail("Unexpected token should fail.");
|
|
} catch (IllegalStateException expected) { }
|
|
}
|
|
|
|
private static TypeAdapter<Date> dateAdapter(TypeAdapterFactory adapterFactory) {
|
|
TypeAdapter<Date> adapter = adapterFactory.create(new Gson(), TypeToken.get(Date.class));
|
|
assertThat(adapter).isNotNull();
|
|
return adapter;
|
|
}
|
|
|
|
private static void assertFormatted(String formatted, TypeAdapterFactory adapterFactory) {
|
|
TypeAdapter<Date> adapter = dateAdapter(adapterFactory);
|
|
assertThat(adapter.toJson(new Date(0))).isEqualTo(toLiteral(formatted));
|
|
}
|
|
|
|
@SuppressWarnings("UndefinedEquals")
|
|
private static void assertParsed(String date, TypeAdapterFactory adapterFactory) throws IOException {
|
|
TypeAdapter<Date> adapter = dateAdapter(adapterFactory);
|
|
assertWithMessage(date).that(adapter.fromJson(toLiteral(date))).isEqualTo(new Date(0));
|
|
assertWithMessage("ISO 8601").that(adapter.fromJson(toLiteral("1970-01-01T00:00:00Z"))).isEqualTo(new Date(0));
|
|
}
|
|
|
|
private static String toLiteral(String s) {
|
|
return '"' + s + '"';
|
|
}
|
|
}
|