dc20b7561a
* Adds `@SuppressWarnings("NarrowingCompoundAssignment")`
* Adds `@SuppressWarnings("TypeParameterUnusedInFormals")`
* Adds `@SuppressWarnings("JavaUtilDate")`
* Adds a limit to `String.split()`
* Add `error_prone_annotations` to the `pom.xml`
* Adds `@InlineMe(...)` to deprecated methods
* Adds `@SuppressWarnings("ImmutableEnumChecker")`
* Adds `@SuppressWarnings("ModifiedButNotUsed")`
* Adds `@SuppressWarnings("MixedMutabilityReturnType")`
* Removes an unused import
* Adds `requires` to `module-info.java`
* Adds ErrorProne `link` into `pom.xml`
* Remove unused imports
Removed from:
- ParseBenchmark
* Adds `@SuppressWarnings("EqualsGetClass")`
* Excludes from `proto` just the generated code.
Replaces `.*proto.*` with `.*/generated-test-sources/protobuf/.*` in such way will be excluded just the generated code and not the whole `proto` directory
* Removes an unused variable
Removes the `descriptor` variable because is unused.
* Fixes the `BadImport` warn into `ProtosWithAnnotationsTest`
* Fixes the `BadImport` warns into `ProtosWithAnnotationsTest`
* Enables ErrorProne in `gson/src/test.*`
Removes the `gson/src/test.*` path from the `-XepExcludedPaths` parameter of the ErrorProne plugin
* Fixes `UnusedVariable` warns
This commit fix all `UnusedVariable` warns given by ErrorProne in the `gson/src/test.*` path.
Some field is annotated with `@Keep` that means is used by reflection.
In some other case the record is annotated with `@SuppressWarnings("unused")`
* Fixes `JavaUtilDate` warns
This commit fix all `JavaUtilDate` warns given by ErrorProne in the `gson/src/test.*` path.
Classes/Methods are annotated with `@SuppressWarnings("JavaUtilDate")` because it's not possible use differente Date API.
* Fixes `EqualsGetClass` warns
This commit fix all `EqualsGetClass` warns given by ErrorProne in the `gson/src/test.*` path.
I have rewrite the `equals()` methods to use `instanceof`
* Replaces pattern matching for instanceof with casts
* Fixes `JdkObsolete` warns
This commit fix all `JdkObsolete` warns given by ErrorProne in the `gson/src/test.*` path.
In some cases I have replaced the obsolete JDK classes with the newest alternatives. In other cases, I have added the `@SuppressWarnings("JdkObsolete")`
* Fixes `ClassCanBeStatic` warns
This commit fix all `ClassCanBeStatic` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `static` keyword, or I have added `@SuppressWarnings("ClassCanBeStatic")`
* Fixes `UndefinedEquals` warns
This commit fix all `UndefinedEquals` warns given by ErrorProne in the `gson/src/test.*` path.
I have added `@SuppressWarnings("UndefinedEquals")` or fixed the asserts
Note: In this commit I have also renamed a test from `testRawCollectionDeserializationNotAlllowed` to `testRawCollectionDeserializationNotAllowed`
* Fixes `GetClassOnEnum` warns
This commit fix all `GetClassOnEnum` warns given by ErrorProne in the `gson/src/test.*` path.
I have replaced the `.getClass()` with `.getDeclaringClass()`
* Fixes `ImmutableEnumChecker` warns
This commit fix all `ImmutableEnumChecker` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `final` keyword, or I have added the `@SuppressWarnings("ImmutableEnumChecker")` annotation
* Fixes `StaticAssignmentOfThrowable` warns
This commit fix all `StaticAssignmentOfThrowable` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `AssertionFailureIgnored` warns
This commit fix all `AssertionFailureIgnored` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `@SuppressWarnings("AssertionFailureIgnored")` annotation
* Fixes `ModifiedButNotUsed` warns
This commit fix all `ModifiedButNotUsed` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `@SuppressWarnings("ModifiedButNotUsed")` annotation
* Fixes `MissingSummary` warns
This commit fix all `MissingSummary` warns given by ErrorProne in the `gson/src/test.*` path.
I have remove the Javadoc `@author`
* Fixes `FloatingPointLiteralPrecision` warns
This commit fix all `FloatingPointLiteralPrecision` warns given by ErrorProne in the `gson/src/test.*` path.
I have added the `@SuppressWarnings("FloatingPointLiteralPrecision")` annotation
* Fixes `StringSplitter` warns
This commit fix all `StringSplitter` warns given by ErrorProne in the `gson/src/test.*` path.
I have replaced the `String.split(...)` with `Splitter`
* Fixes `EmptyCatch` warns
This commit fix all `EmptyCatch` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `UnicodeEscape` warns
This commit fix all `UnicodeEscape` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `EmptyBlockTag` warns
This commit fix all `EmptyBlockTag` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `LongFloatConversion` warns
This commit fix all `LongFloatConversion` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `LongDoubleConversion` warns
This commit fix all `LongDoubleConversion` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `TruthAssertExpected` warns
This commit fix all `TruthAssertExpected` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `UnusedMethod` warns
This commit fix all `UnusedMethod` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `UnusedTypeParameter` warns
This commit fix all `UnusedTypeParameter` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `CatchFail` warns
This commit fix all `CatchFail` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `MathAbsoluteNegative` warns
This commit fix all `MathAbsoluteNegative` warns given by ErrorProne in the `gson/src/test.*` path.
* Fixes `LoopOverCharArray` warns
This commit fix all `LoopOverCharArray` warns given by ErrorProne in the `gson/src/test.*` path.
`toCharArray` allocates a new array, using `charAt` is more efficient
* Fixes `HidingField` warns
This commit fix all `HidingField` warns given by ErrorProne in the `gson/src/test.*` path.
* Implements code review feedback
* Implements code review feedback
This commit implements some other code review feedback
* Enable ErrorProne in `extra`
Thi commit removes the `.*extras/src/test.*` path from the `-XepExcludedPaths` parameter of ErrorProne.
* Fix the `JavaUtilDate` warns
This commit fix all `JavaUtilDate` warns given by ErrorProne in the `extras/src/test.*` path.
* Implements code review feedback
* Removes redundant new-line
* Implements code review feedback
* Adds `JDK11` to run test with `--release 11`
* Revert "Adds `JDK11` to run test with `--release 11`"
This reverts commit a7cca386098ae847a10a31c09c3ab9b11eee5920.
101 lines
3.4 KiB
Java
101 lines
3.4 KiB
Java
/*
|
|
* Copyright (C) 2008 Google Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.google.gson;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import com.google.errorprone.annotations.Keep;
|
|
import com.google.gson.annotations.Since;
|
|
import com.google.gson.annotations.Until;
|
|
import com.google.gson.internal.Excluder;
|
|
import org.junit.Test;
|
|
|
|
/**
|
|
* Unit tests for the {@link Excluder} class.
|
|
*
|
|
* @author Joel Leitch
|
|
*/
|
|
public class VersionExclusionStrategyTest {
|
|
private static final double VERSION = 5.0D;
|
|
|
|
@Test
|
|
public void testSameVersion() throws Exception {
|
|
Excluder excluder = Excluder.DEFAULT.withVersion(VERSION);
|
|
assertThat(excluder.excludeClass(MockClassSince.class, true)).isFalse();
|
|
assertThat(excluder.excludeField(MockClassSince.class.getField("someField"), true)).isFalse();
|
|
|
|
// Until version is exclusive
|
|
assertThat(excluder.excludeClass(MockClassUntil.class, true)).isTrue();
|
|
assertThat(excluder.excludeField(MockClassUntil.class.getField("someField"), true)).isTrue();
|
|
|
|
assertThat(excluder.excludeClass(MockClassBoth.class, true)).isFalse();
|
|
assertThat(excluder.excludeField(MockClassBoth.class.getField("someField"), true)).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void testNewerVersion() throws Exception {
|
|
Excluder excluder = Excluder.DEFAULT.withVersion(VERSION + 5);
|
|
assertThat(excluder.excludeClass(MockClassSince.class, true)).isFalse();
|
|
assertThat(excluder.excludeField(MockClassSince.class.getField("someField"), true)).isFalse();
|
|
|
|
assertThat(excluder.excludeClass(MockClassUntil.class, true)).isTrue();
|
|
assertThat(excluder.excludeField(MockClassUntil.class.getField("someField"), true)).isTrue();
|
|
|
|
assertThat(excluder.excludeClass(MockClassBoth.class, true)).isTrue();
|
|
assertThat(excluder.excludeField(MockClassBoth.class.getField("someField"), true)).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void testOlderVersion() throws Exception {
|
|
Excluder excluder = Excluder.DEFAULT.withVersion(VERSION - 5);
|
|
assertThat(excluder.excludeClass(MockClassSince.class, true)).isTrue();
|
|
assertThat(excluder.excludeField(MockClassSince.class.getField("someField"), true)).isTrue();
|
|
|
|
assertThat(excluder.excludeClass(MockClassUntil.class, true)).isFalse();
|
|
assertThat(excluder.excludeField(MockClassUntil.class.getField("someField"), true)).isFalse();
|
|
|
|
assertThat(excluder.excludeClass(MockClassBoth.class, true)).isTrue();
|
|
assertThat(excluder.excludeField(MockClassBoth.class.getField("someField"), true)).isTrue();
|
|
}
|
|
|
|
@Since(VERSION)
|
|
private static class MockClassSince {
|
|
|
|
@Since(VERSION)
|
|
@Keep
|
|
public final int someField = 0;
|
|
}
|
|
|
|
@Until(VERSION)
|
|
private static class MockClassUntil {
|
|
|
|
@Until(VERSION)
|
|
@Keep
|
|
public final int someField = 0;
|
|
}
|
|
|
|
@Since(VERSION)
|
|
@Until(VERSION + 2)
|
|
private static class MockClassBoth {
|
|
|
|
@Since(VERSION)
|
|
@Until(VERSION + 2)
|
|
@Keep
|
|
public final int someField = 0;
|
|
}
|
|
}
|