![Maicol](/assets/img/avatar_default.png)
* Adds `@SuppressWarnings("NarrowingCompoundAssignment")` * Adds `@SuppressWarnings("TypeParameterUnusedInFormals")` * Adds `@SuppressWarnings("JavaUtilDate")` * Adds a limit to `String.split()` * Add `error_prone_annotations` to the `pom.xml` * Adds `@InlineMe(...)` to deprecated methods * Adds `@SuppressWarnings("ImmutableEnumChecker")` * Adds `@SuppressWarnings("ModifiedButNotUsed")` * Adds `@SuppressWarnings("MixedMutabilityReturnType")` * Removes an unused import * Adds `requires` to `module-info.java` * Adds ErrorProne `link` into `pom.xml` * Remove unused imports Removed from: - ParseBenchmark * Adds `@SuppressWarnings("EqualsGetClass")` * Excludes from `proto` just the generated code. Replaces `.*proto.*` with `.*/generated-test-sources/protobuf/.*` in such way will be excluded just the generated code and not the whole `proto` directory * Removes an unused variable Removes the `descriptor` variable because is unused. * Fixes the `BadImport` warn into `ProtosWithAnnotationsTest` * Fixes the `BadImport` warns into `ProtosWithAnnotationsTest` * Enables ErrorProne in `gson/src/test.*` Removes the `gson/src/test.*` path from the `-XepExcludedPaths` parameter of the ErrorProne plugin * Fixes `UnusedVariable` warns This commit fix all `UnusedVariable` warns given by ErrorProne in the `gson/src/test.*` path. Some field is annotated with `@Keep` that means is used by reflection. In some other case the record is annotated with `@SuppressWarnings("unused")` * Fixes `JavaUtilDate` warns This commit fix all `JavaUtilDate` warns given by ErrorProne in the `gson/src/test.*` path. Classes/Methods are annotated with `@SuppressWarnings("JavaUtilDate")` because it's not possible use differente Date API. * Fixes `EqualsGetClass` warns This commit fix all `EqualsGetClass` warns given by ErrorProne in the `gson/src/test.*` path. I have rewrite the `equals()` methods to use `instanceof` * Replaces pattern matching for instanceof with casts * Fixes `JdkObsolete` warns This commit fix all `JdkObsolete` warns given by ErrorProne in the `gson/src/test.*` path. In some cases I have replaced the obsolete JDK classes with the newest alternatives. In other cases, I have added the `@SuppressWarnings("JdkObsolete")` * Fixes `ClassCanBeStatic` warns This commit fix all `ClassCanBeStatic` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `static` keyword, or I have added `@SuppressWarnings("ClassCanBeStatic")` * Fixes `UndefinedEquals` warns This commit fix all `UndefinedEquals` warns given by ErrorProne in the `gson/src/test.*` path. I have added `@SuppressWarnings("UndefinedEquals")` or fixed the asserts Note: In this commit I have also renamed a test from `testRawCollectionDeserializationNotAlllowed` to `testRawCollectionDeserializationNotAllowed` * Fixes `GetClassOnEnum` warns This commit fix all `GetClassOnEnum` warns given by ErrorProne in the `gson/src/test.*` path. I have replaced the `.getClass()` with `.getDeclaringClass()` * Fixes `ImmutableEnumChecker` warns This commit fix all `ImmutableEnumChecker` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `final` keyword, or I have added the `@SuppressWarnings("ImmutableEnumChecker")` annotation * Fixes `StaticAssignmentOfThrowable` warns This commit fix all `StaticAssignmentOfThrowable` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `AssertionFailureIgnored` warns This commit fix all `AssertionFailureIgnored` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `@SuppressWarnings("AssertionFailureIgnored")` annotation * Fixes `ModifiedButNotUsed` warns This commit fix all `ModifiedButNotUsed` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `@SuppressWarnings("ModifiedButNotUsed")` annotation * Fixes `MissingSummary` warns This commit fix all `MissingSummary` warns given by ErrorProne in the `gson/src/test.*` path. I have remove the Javadoc `@author` * Fixes `FloatingPointLiteralPrecision` warns This commit fix all `FloatingPointLiteralPrecision` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `@SuppressWarnings("FloatingPointLiteralPrecision")` annotation * Fixes `StringSplitter` warns This commit fix all `StringSplitter` warns given by ErrorProne in the `gson/src/test.*` path. I have replaced the `String.split(...)` with `Splitter` * Fixes `EmptyCatch` warns This commit fix all `EmptyCatch` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `UnicodeEscape` warns This commit fix all `UnicodeEscape` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `EmptyBlockTag` warns This commit fix all `EmptyBlockTag` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `LongFloatConversion` warns This commit fix all `LongFloatConversion` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `LongDoubleConversion` warns This commit fix all `LongDoubleConversion` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `TruthAssertExpected` warns This commit fix all `TruthAssertExpected` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `UnusedMethod` warns This commit fix all `UnusedMethod` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `UnusedTypeParameter` warns This commit fix all `UnusedTypeParameter` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `CatchFail` warns This commit fix all `CatchFail` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `MathAbsoluteNegative` warns This commit fix all `MathAbsoluteNegative` warns given by ErrorProne in the `gson/src/test.*` path. * Fixes `LoopOverCharArray` warns This commit fix all `LoopOverCharArray` warns given by ErrorProne in the `gson/src/test.*` path. `toCharArray` allocates a new array, using `charAt` is more efficient * Fixes `HidingField` warns This commit fix all `HidingField` warns given by ErrorProne in the `gson/src/test.*` path. * Implements code review feedback * Implements code review feedback This commit implements some other code review feedback * Enable ErrorProne in `extra` Thi commit removes the `.*extras/src/test.*` path from the `-XepExcludedPaths` parameter of ErrorProne. * Fix the `JavaUtilDate` warns This commit fix all `JavaUtilDate` warns given by ErrorProne in the `extras/src/test.*` path. * Implements code review feedback * Removes redundant new-line * Implements code review feedback * Adds `JDK11` to run test with `--release 11` * Revert "Adds `JDK11` to run test with `--release 11`" This reverts commit a7cca386098ae847a10a31c09c3ab9b11eee5920.
166 lines
5.6 KiB
Java
166 lines
5.6 KiB
Java
/*
|
|
* Copyright (C) 2008 Google Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.google.gson;
|
|
|
|
import com.google.common.base.Objects;
|
|
import com.google.gson.internal.$Gson$Types;
|
|
|
|
import com.google.gson.internal.Primitives;
|
|
import java.lang.reflect.InvocationTargetException;
|
|
import java.lang.reflect.Method;
|
|
import java.lang.reflect.ParameterizedType;
|
|
import java.lang.reflect.Type;
|
|
|
|
|
|
/**
|
|
* This class contains some test fixtures for Parameterized types. These classes should ideally
|
|
* belong either in the common or functional package, but they are placed here because they need
|
|
* access to package protected elements of com.google.gson.
|
|
*
|
|
* @author Inderjeet Singh
|
|
* @author Joel Leitch
|
|
*/
|
|
public class ParameterizedTypeFixtures {
|
|
|
|
public static final class MyParameterizedType<T> {
|
|
public final T value;
|
|
public MyParameterizedType(T value) {
|
|
this.value = value;
|
|
}
|
|
public T getValue() {
|
|
return value;
|
|
}
|
|
|
|
public String getExpectedJson() {
|
|
String valueAsJson = getExpectedJson(value);
|
|
return String.format("{\"value\":%s}", valueAsJson);
|
|
}
|
|
|
|
private String getExpectedJson(Object obj) {
|
|
Class<?> clazz = obj.getClass();
|
|
if (Primitives.isWrapperType(Primitives.wrap(clazz))) {
|
|
return obj.toString();
|
|
} else if (obj.getClass().equals(String.class)) {
|
|
return "\"" + obj.toString() + "\"";
|
|
} else {
|
|
// Try invoking a getExpectedJson() method if it exists
|
|
try {
|
|
Method method = clazz.getMethod("getExpectedJson");
|
|
Object results = method.invoke(obj);
|
|
return (String) results;
|
|
} catch (SecurityException e) {
|
|
throw new RuntimeException(e);
|
|
} catch (NoSuchMethodException e) {
|
|
throw new RuntimeException(e);
|
|
} catch (IllegalArgumentException e) {
|
|
throw new RuntimeException(e);
|
|
} catch (IllegalAccessException e) {
|
|
throw new RuntimeException(e);
|
|
} catch (InvocationTargetException e) {
|
|
throw new RuntimeException(e);
|
|
}
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public int hashCode() {
|
|
return value == null ? 0 : value.hashCode();
|
|
}
|
|
|
|
@Override
|
|
public boolean equals(Object obj) {
|
|
if (this == obj) {
|
|
return true;
|
|
}
|
|
if (!(obj instanceof MyParameterizedType<?>)) {
|
|
return false;
|
|
}
|
|
MyParameterizedType<?> that = (MyParameterizedType<?>) obj;
|
|
return Objects.equal(getValue(), that.getValue());
|
|
}
|
|
}
|
|
|
|
public static class MyParameterizedTypeInstanceCreator<T>
|
|
implements InstanceCreator<MyParameterizedType<T>>{
|
|
private final T instanceOfT;
|
|
/**
|
|
* Caution the specified instance is reused by the instance creator for each call.
|
|
* This means that the fields of the same objects will be overwritten by Gson.
|
|
* This is usually fine in tests since there we deserialize just once, but quite
|
|
* dangerous in practice.
|
|
*/
|
|
public MyParameterizedTypeInstanceCreator(T instanceOfT) {
|
|
this.instanceOfT = instanceOfT;
|
|
}
|
|
@Override public MyParameterizedType<T> createInstance(Type type) {
|
|
return new MyParameterizedType<>(instanceOfT);
|
|
}
|
|
}
|
|
|
|
public static final class MyParameterizedTypeAdapter<T>
|
|
implements JsonSerializer<MyParameterizedType<T>>, JsonDeserializer<MyParameterizedType<T>> {
|
|
@SuppressWarnings("unchecked")
|
|
public static<T> String getExpectedJson(MyParameterizedType<T> obj) {
|
|
Class<T> clazz = (Class<T>) obj.value.getClass();
|
|
boolean addQuotes = !clazz.isArray() && !Primitives.unwrap(clazz).isPrimitive();
|
|
StringBuilder sb = new StringBuilder("{\"");
|
|
sb.append(obj.value.getClass().getSimpleName()).append("\":");
|
|
if (addQuotes) {
|
|
sb.append("\"");
|
|
}
|
|
sb.append(obj.value.toString());
|
|
if (addQuotes) {
|
|
sb.append("\"");
|
|
}
|
|
sb.append("}");
|
|
return sb.toString();
|
|
}
|
|
|
|
@Override public JsonElement serialize(MyParameterizedType<T> src, Type classOfSrc,
|
|
JsonSerializationContext context) {
|
|
JsonObject json = new JsonObject();
|
|
T value = src.getValue();
|
|
json.add(value.getClass().getSimpleName(), context.serialize(value));
|
|
return json;
|
|
}
|
|
|
|
@SuppressWarnings("unchecked")
|
|
@Override public MyParameterizedType<T> deserialize(JsonElement json, Type typeOfT,
|
|
JsonDeserializationContext context) throws JsonParseException {
|
|
Type genericClass = ((ParameterizedType) typeOfT).getActualTypeArguments()[0];
|
|
Class<?> rawType = $Gson$Types.getRawType(genericClass);
|
|
String className = rawType.getSimpleName();
|
|
JsonElement jsonElement = json.getAsJsonObject().get(className);
|
|
|
|
T value;
|
|
if (genericClass == Integer.class) {
|
|
value = (T) Integer.valueOf(jsonElement.getAsInt());
|
|
} else if (genericClass == String.class) {
|
|
value = (T) jsonElement.getAsString();
|
|
} else {
|
|
value = (T) jsonElement;
|
|
}
|
|
|
|
if (Primitives.isPrimitive(genericClass)) {
|
|
PrimitiveTypeAdapter typeAdapter = new PrimitiveTypeAdapter();
|
|
value = (T) typeAdapter.adaptType(value, rawType);
|
|
}
|
|
return new MyParameterizedType<>(value);
|
|
}
|
|
}
|
|
}
|