Johannes/gson-comments
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

changed synchronization on Date type adapter to be for the format object per code review comments on r452

Browse Source
This commit is contained in:
Inderjeet Singh 2009-09-30 23:11:30 +00:00
parent 907082102d
commit fbefa59b66
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gson/src/main/java/com/google/gson/DefaultTypeAdapters.java
View File

@ -251,21 +251,22 @@ final class DefaultTypeAdapters {
// These methods need to be synchronized since JDK DateFormat classes are not thread-safe
// See issue 162
public synchronized JsonElement serialize(
Date src, Type typeOfSrc, JsonSerializationContext context) {
String dateFormatAsString = format.format(src);
return new JsonPrimitive(dateFormatAsString);
public JsonElement serialize(Date src, Type typeOfSrc, JsonSerializationContext context) {
synchronized (format) {
String dateFormatAsString = format.format(src);
return new JsonPrimitive(dateFormatAsString);
}
}
public synchronized Date deserialize(
JsonElement json, Type typeOfT, JsonDeserializationContext context)
public Date deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context)
throws JsonParseException {
if (!(json instanceof JsonPrimitive)) {
throw new JsonParseException("The date should be a string value");
}
try {
return format.parse(json.getAsString());
synchronized (format) {
return format.parse(json.getAsString());
}
} catch (ParseException e) {
throw new JsonParseException(e);
}