Johannes/gson-comments
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Delete some obsolete TODOs

Browse Source
This commit is contained in:
Jesse Wilson 2012-01-01 12:42:48 +00:00
parent 796a381279
commit d4a1e49e46
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gson/src/main/java/com/google/gson/internal/bind/CollectionTypeAdapterFactory.java
View File

@ -87,7 +87,7 @@ public final class CollectionTypeAdapterFactory implements TypeAdapterFactory {
public void write(JsonWriter out, Collection<E> collection) throws IOException {
if (collection == null) {
out.nullValue(); // TODO: better policy here?
out.nullValue();
return;
}

11
gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java
View File

@ -153,8 +153,7 @@ public final class ReflectiveTypeAdapterFactory implements TypeAdapterFactory {
this.boundFields = boundFields;
}
@Override
public T read(JsonReader in) throws IOException {
@Override public T read(JsonReader in) throws IOException {
if (in.peek() == JsonToken.NULL) {
in.nextNull();
return null;
@ -162,15 +161,12 @@ public final class ReflectiveTypeAdapterFactory implements TypeAdapterFactory {
T instance = constructor.construct();
// TODO: null out the other fields?
try {
in.beginObject();
while (in.hasNext()) {
String name = in.nextName();
BoundField field = boundFields.get(name);
if (field == null || !field.deserialized) {
// TODO: define a better policy
in.skipValue();
} else {
field.read(in, instance);
@ -185,10 +181,9 @@ public final class ReflectiveTypeAdapterFactory implements TypeAdapterFactory {
return instance;
}
@Override
public void write(JsonWriter out, T value) throws IOException {
@Override public void write(JsonWriter out, T value) throws IOException {
if (value == null) {
out.nullValue(); // TODO: better policy here?
out.nullValue();
return;
}