Incorporating code review suggestions

This commit is contained in:
Mohammad Yasir 2017-02-17 07:25:23 +05:30
parent ba4643134a
commit 9c30b0e203

View File

@ -997,7 +997,7 @@ public class JsonReader implements Closeable {
if (c == quote) { if (c == quote) {
pos = p; pos = p;
int len = p - start - 1; int len = p - start - 1;
if(null == builder) { if (builder == null) {
return new String(buffer, start, len); return new String(buffer, start, len);
} else { } else {
builder.append(buffer, start, len); builder.append(buffer, start, len);
@ -1007,9 +1007,9 @@ public class JsonReader implements Closeable {
pos = p; pos = p;
int len = p - start - 1; int len = p - start - 1;
char escapeChar = readEscapeCharacter(); char escapeChar = readEscapeCharacter();
if(null == builder) { if (builder == null) {
int estimatedLength = (len + pos - p) * 2; int estimatedLength = (len + pos - p) * 2;
builder = new StringBuilder(estimatedLength < 16 ? 16 : estimatedLength); builder = new StringBuilder(Math.max(estimatedLength, 16));
} }
builder.append(buffer, start, len); builder.append(buffer, start, len);
builder.append(escapeChar); builder.append(escapeChar);
@ -1022,9 +1022,9 @@ public class JsonReader implements Closeable {
} }
} }
if(null == builder) { if (builder == null) {
int len = (p - start) * 2; int estimatedLength = (p - start) * 2;
builder = new StringBuilder(len < 16 ? 16 : len); builder = new StringBuilder(Math.max(estimatedLength, 16));
} }
builder.append(buffer, start, p - start); builder.append(buffer, start, p - start);
pos = p; pos = p;