Johannes/gson-comments
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't unwrap single-element String arrays

Browse Source
This commit is contained in:
Jesse Wilson 2011-09-09 05:41:35 +00:00
parent 99801915aa
commit 9424949245
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gson/GSON 2.0 NOTES.txt
View File

@ -10,7 +10,7 @@ com.google.gson.functional.PrimitiveTest.testPrimitiveBooleanAutoboxedInASingleE
com.google.gson.functional.PrimitiveTest.testPrimitiveDoubleAutoboxedInASingleElementArrayDeserialization com.google.gson.functional.PrimitiveTest.testPrimitiveDoubleAutoboxedInASingleElementArrayDeserialization
com.google.gson.functional.PrimitiveTest.testBigDecimalInASingleElementArrayDeserialization com.google.gson.functional.PrimitiveTest.testBigDecimalInASingleElementArrayDeserialization
com.google.gson.functional.PrimitiveTest.testBigIntegerInASingleElementArrayDeserialization com.google.gson.functional.PrimitiveTest.testBigIntegerInASingleElementArrayDeserialization
com.google.gson.functional.StringTest.testStringValueAsSingleElementArrayDeserialization
GSON 1.x permitted primitive types to be overridden GSON 1.x permitted primitive types to be overridden
GSON 2.x doesn't. GSON 2.x doesn't.

16
gson/src/test/java/com/google/gson/functional/StringTest.java
View File

@ -18,7 +18,7 @@ public class StringTest extends TestCase {
super.setUp(); super.setUp();
gson = new Gson(); gson = new Gson();
} }
public void testStringValueSerialization() throws Exception { public void testStringValueSerialization() throws Exception {
String value = "someRandomStringValue"; String value = "someRandomStringValue";
assertEquals('"' + value + '"', gson.toJson(value)); assertEquals('"' + value + '"', gson.toJson(value));
@ -97,19 +97,13 @@ public class StringTest extends TestCase {
assertEquals("[\"abc\"]", gson.toJson(target, String[].class)); assertEquals("[\"abc\"]", gson.toJson(target, String[].class));
} }
public void testStringValueAsSingleElementArrayDeserialization() throws Exception {
String value = "someRandomStringValue";
String actual = gson.fromJson("[\"" + value + "\"]", String.class);
assertEquals(value, actual);
}
public void testStringWithEscapedSlashDeserialization() { public void testStringWithEscapedSlashDeserialization() {
String value = "/"; String value = "/";
String json = "'\\/'"; String json = "'\\/'";
String actual = gson.fromJson(json, String.class); String actual = gson.fromJson(json, String.class);
assertEquals(value, actual); assertEquals(value, actual);
} }
/** /**
* Created in response to http://groups.google.com/group/google-gson/browse_thread/thread/2431d4a3d0d6cb23 * Created in response to http://groups.google.com/group/google-gson/browse_thread/thread/2431d4a3d0d6cb23
*/ */
@ -118,7 +112,7 @@ public class StringTest extends TestCase {
String json = gson.toJson(value); String json = gson.toJson(value);
assertEquals("\"abc\\u003d\"", json); assertEquals("\"abc\\u003d\"", json);
} }
/** /**
* Created in response to http://groups.google.com/group/google-gson/browse_thread/thread/2431d4a3d0d6cb23 * Created in response to http://groups.google.com/group/google-gson/browse_thread/thread/2431d4a3d0d6cb23
*/ */
@ -131,13 +125,13 @@ public class StringTest extends TestCase {
value = gson.fromJson(json, String.class); value = gson.fromJson(json, String.class);
assertEquals("abc=", value); assertEquals("abc=", value);
} }
public void testJavascriptKeywordsInStringSerialization() { public void testJavascriptKeywordsInStringSerialization() {
String value = "null true false function"; String value = "null true false function";
String json = gson.toJson(value); String json = gson.toJson(value);
assertEquals("\"" + value + "\"", json); assertEquals("\"" + value + "\"", json);
} }
public void testJavascriptKeywordsInStringDeserialization() { public void testJavascriptKeywordsInStringDeserialization() {
String json = "'null true false function'"; String json = "'null true false function'";
String value = gson.fromJson(json, String.class); String value = gson.fromJson(json, String.class);