Update Error Prone, bypass a bug in it, fix some problems it flags (#2387)
This commit is contained in:
parent
b330ad9790
commit
49dbc6f072
|
@ -99,7 +99,7 @@ public class FieldNamingPolicyTest {
|
||||||
try {
|
try {
|
||||||
// Verify that default Locale has different case conversion rules
|
// Verify that default Locale has different case conversion rules
|
||||||
assertWithMessage("Test setup is broken")
|
assertWithMessage("Test setup is broken")
|
||||||
.that(name.toUpperCase()).doesNotMatch(expected);
|
.that(name.toUpperCase(Locale.getDefault())).doesNotMatch(expected);
|
||||||
|
|
||||||
for (FieldNamingPolicy policy : policies) {
|
for (FieldNamingPolicy policy : policies) {
|
||||||
// Should ignore default Locale
|
// Should ignore default Locale
|
||||||
|
@ -138,7 +138,7 @@ public class FieldNamingPolicyTest {
|
||||||
try {
|
try {
|
||||||
// Verify that default Locale has different case conversion rules
|
// Verify that default Locale has different case conversion rules
|
||||||
assertWithMessage("Test setup is broken")
|
assertWithMessage("Test setup is broken")
|
||||||
.that(name.toLowerCase()).doesNotMatch(expected);
|
.that(name.toLowerCase(Locale.getDefault())).doesNotMatch(expected);
|
||||||
|
|
||||||
for (FieldNamingPolicy policy : policies) {
|
for (FieldNamingPolicy policy : policies) {
|
||||||
// Should ignore default Locale
|
// Should ignore default Locale
|
||||||
|
|
8
pom.xml
8
pom.xml
|
@ -132,7 +132,11 @@
|
||||||
<compilerArgs>
|
<compilerArgs>
|
||||||
<!-- Args related to Error Prone, see: https://errorprone.info/docs/installation#maven -->
|
<!-- Args related to Error Prone, see: https://errorprone.info/docs/installation#maven -->
|
||||||
<arg>-XDcompilePolicy=simple</arg>
|
<arg>-XDcompilePolicy=simple</arg>
|
||||||
<arg>-Xplugin:ErrorProne -XepExcludedPaths:.*/generated-test-sources/protobuf/.*</arg>
|
<arg>-Xplugin:ErrorProne
|
||||||
|
-XepExcludedPaths:.*/generated-test-sources/protobuf/.*
|
||||||
|
-Xep:HidingField:OFF <!-- https://github.com/google/error-prone/issues/3895 -->
|
||||||
|
-Xep:NotJavadoc:OFF <!-- Triggered by local class. -->
|
||||||
|
</arg>
|
||||||
<!-- Enable all warnings, except for ones which cause issues when building with newer JDKs, see also
|
<!-- Enable all warnings, except for ones which cause issues when building with newer JDKs, see also
|
||||||
https://docs.oracle.com/en/java/javase/11/tools/javac.html -->
|
https://docs.oracle.com/en/java/javase/11/tools/javac.html -->
|
||||||
<compilerArg>-Xlint:all,-options</compilerArg>
|
<compilerArg>-Xlint:all,-options</compilerArg>
|
||||||
|
@ -141,7 +145,7 @@
|
||||||
<path>
|
<path>
|
||||||
<groupId>com.google.errorprone</groupId>
|
<groupId>com.google.errorprone</groupId>
|
||||||
<artifactId>error_prone_core</artifactId>
|
<artifactId>error_prone_core</artifactId>
|
||||||
<version>2.18.0</version>
|
<version>2.19.0</version>
|
||||||
</path>
|
</path>
|
||||||
</annotationProcessorPaths>
|
</annotationProcessorPaths>
|
||||||
</configuration>
|
</configuration>
|
||||||
|
|
Loading…
Reference in New Issue
Block a user