Johannes/gson-comments
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Implemented equals and hashcode for LazilyParsedNumber to fix

Browse Source 
https://github.com/google/gson/issues/627
This commit is contained in:
Inderjeet Singh 2015-09-26 17:58:13 -07:00
parent 93605e7145
commit 3daf585931
2 changed files with 131 additions and 77 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
gson/src/main/java/com/google/gson/internal/LazilyParsedNumber.java
View File

@ -75,4 +75,26 @@ public final class LazilyParsedNumber extends Number {
private Object writeReplace() throws ObjectStreamException { private Object writeReplace() throws ObjectStreamException {
return new BigDecimal(value); return new BigDecimal(value);
} }
@Override
public int hashCode() {
return value == null ? 0 : value.hashCode();
}
@Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
}
if (obj == null || !(obj instanceof LazilyParsedNumber)) {
return false;
}
LazilyParsedNumber other = (LazilyParsedNumber) obj;
return equals(value, other.value);
}
private static boolean equals(Object obj1, Object obj2) {
if (obj1 == null) return obj2 == null;
return obj1 == obj2 || obj1.equals(obj2);
}
} }

32
gson/src/test/java/com/google/gson/internal/LazilyParsedNumberTest.java Normal file
View File

@ -0,0 +1,32 @@
/*
* Copyright (C) 2015 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.gson.internal;
import junit.framework.TestCase;
public class LazilyParsedNumberTest extends TestCase {
public void testHashCode(){
LazilyParsedNumber n1 = new LazilyParsedNumber("1");
LazilyParsedNumber n1Another = new LazilyParsedNumber("1");
assertEquals(n1.hashCode(), n1Another.hashCode());
}
public void testEquals(){
LazilyParsedNumber n1 = new LazilyParsedNumber("1");
LazilyParsedNumber n1Another = new LazilyParsedNumber("1");
assertTrue(n1.equals(n1Another));
}
}