Johannes/gson-comments
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prefer writing chars instead of strings of length one (#1576)

Browse Source 
This results in a noticeable performance improvement with most writer
implementations (including BufferedWriter).
This commit is contained in:
David Maplesden 2019-09-19 05:33:49 +12:00 committed by inder123
parent f885e602f1
commit 3958b1f78d
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gson/src/main/java/com/google/gson/stream/JsonWriter.java
View File

@ -286,7 +286,7 @@ public class JsonWriter implements Closeable, Flushable {
*/ */
public JsonWriter beginArray() throws IOException { public JsonWriter beginArray() throws IOException {
writeDeferredName(); writeDeferredName();
return open(EMPTY_ARRAY, "["); return open(EMPTY_ARRAY, '[');
} }
/** /**
@ -295,7 +295,7 @@ public class JsonWriter implements Closeable, Flushable {
* @return this writer. * @return this writer.
*/ */
public JsonWriter endArray() throws IOException { public JsonWriter endArray() throws IOException {
return close(EMPTY_ARRAY, NONEMPTY_ARRAY, "]"); return close(EMPTY_ARRAY, NONEMPTY_ARRAY, ']');
} }
/** /**
@ -306,7 +306,7 @@ public class JsonWriter implements Closeable, Flushable {
*/ */
public JsonWriter beginObject() throws IOException { public JsonWriter beginObject() throws IOException {
writeDeferredName(); writeDeferredName();
return open(EMPTY_OBJECT, "{"); return open(EMPTY_OBJECT, '{');
} }
/** /**
@ -315,14 +315,14 @@ public class JsonWriter implements Closeable, Flushable {
* @return this writer. * @return this writer.
*/ */
public JsonWriter endObject() throws IOException { public JsonWriter endObject() throws IOException {
return close(EMPTY_OBJECT, NONEMPTY_OBJECT, "}"); return close(EMPTY_OBJECT, NONEMPTY_OBJECT, '}');
} }
/** /**
* Enters a new scope by appending any necessary whitespace and the given * Enters a new scope by appending any necessary whitespace and the given
* bracket. * bracket.
*/ */
private JsonWriter open(int empty, String openBracket) throws IOException { private JsonWriter open(int empty, char openBracket) throws IOException {
beforeValue(); beforeValue();
push(empty); push(empty);
out.write(openBracket); out.write(openBracket);
@ -333,7 +333,7 @@ public class JsonWriter implements Closeable, Flushable {
* Closes the current scope by appending any necessary whitespace and the * Closes the current scope by appending any necessary whitespace and the
* given bracket. * given bracket.
*/ */
private JsonWriter close(int empty, int nonempty, String closeBracket) private JsonWriter close(int empty, int nonempty, char closeBracket)
throws IOException { throws IOException {
int context = peek(); int context = peek();
if (context != nonempty && context != empty) { if (context != nonempty && context != empty) {
@ -562,7 +562,7 @@ public class JsonWriter implements Closeable, Flushable {
private void string(String value) throws IOException { private void string(String value) throws IOException {
String[] replacements = htmlSafe ? HTML_SAFE_REPLACEMENT_CHARS : REPLACEMENT_CHARS; String[] replacements = htmlSafe ? HTML_SAFE_REPLACEMENT_CHARS : REPLACEMENT_CHARS;
out.write("\""); out.write('\"');
int last = 0; int last = 0;
int length = value.length(); int length = value.length();
for (int i = 0; i < length; i++) { for (int i = 0; i < length; i++) {
@ -589,7 +589,7 @@ public class JsonWriter implements Closeable, Flushable {
if (last < length) { if (last < length) {
out.write(value, last, length - last); out.write(value, last, length - last);
} }
out.write("\""); out.write('\"');
} }
private void newline() throws IOException { private void newline() throws IOException {
@ -597,7 +597,7 @@ public class JsonWriter implements Closeable, Flushable {
return; return;
} }
out.write("\n"); out.write('\n');
for (int i = 1, size = stackSize; i < size; i++) { for (int i = 1, size = stackSize; i < size; i++) {
out.write(indent); out.write(indent);
} }