Johannes/gson-comments
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Adding a few more assert to the InstanceCreatorTest to ensure that the default values are set for sub class fields.

Browse Source
This commit is contained in:
Joel Leitch 2009-10-09 21:23:51 +00:00
parent d87d3f807f
commit 102f8b3a71
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
gson/src/test/java/com/google/gson/functional/InstanceCreatorTest.java
View File

@ -16,10 +16,6 @@
package com.google.gson.functional; package com.google.gson.functional;
import java.lang.reflect.Type;
import junit.framework.TestCase;
import com.google.gson.Gson; import com.google.gson.Gson;
import com.google.gson.GsonBuilder; import com.google.gson.GsonBuilder;
import com.google.gson.InstanceCreator; import com.google.gson.InstanceCreator;
@ -27,14 +23,18 @@ import com.google.gson.common.TestTypes.Base;
import com.google.gson.common.TestTypes.ClassWithBaseField; import com.google.gson.common.TestTypes.ClassWithBaseField;
import com.google.gson.common.TestTypes.Sub; import com.google.gson.common.TestTypes.Sub;
import junit.framework.TestCase;
import java.lang.reflect.Type;
/** /**
* Functional Test exercising custom serialization only. When test applies to both * Functional Test exercising custom serialization only. When test applies to both
* serialization and deserialization then add it to CustomTypeAdapterTest. * serialization and deserialization then add it to CustomTypeAdapterTest.
* *
* @author Inderjeet Singh * @author Inderjeet Singh
*/ */
public class InstanceCreatorTest extends TestCase { public class InstanceCreatorTest extends TestCase {
public void testInstanceCreatorReturnsBaseType() { public void testInstanceCreatorReturnsBaseType() {
Gson gson = new GsonBuilder() Gson gson = new GsonBuilder()
.registerTypeAdapter(Base.class, new InstanceCreator<Base>() { .registerTypeAdapter(Base.class, new InstanceCreator<Base>() {
@ -47,7 +47,7 @@ public class InstanceCreatorTest extends TestCase {
Base base = gson.fromJson(json, Base.class); Base base = gson.fromJson(json, Base.class);
assertEquals("BaseRevised", base.baseName); assertEquals("BaseRevised", base.baseName);
} }
public void testInstanceCreatorReturnsSubTypeForTopLevelObject() { public void testInstanceCreatorReturnsSubTypeForTopLevelObject() {
Gson gson = new GsonBuilder() Gson gson = new GsonBuilder()
.registerTypeAdapter(Base.class, new InstanceCreator<Base>() { .registerTypeAdapter(Base.class, new InstanceCreator<Base>() {
@ -56,11 +56,16 @@ public class InstanceCreatorTest extends TestCase {
} }
}) })
.create(); .create();
String json = "{baseName:'Base',subName:'SubRevised'}"; String json = "{baseName:'Base',subName:'SubRevised'}";
Base base = gson.fromJson(json, Base.class); Base base = gson.fromJson(json, Base.class);
assertFalse("SubRevised".equals(((Sub)base).subName)); assertTrue(base instanceof Sub);
Sub sub = (Sub) base;
assertFalse("SubRevised".equals(sub.subName));
assertEquals(Sub.SUB_NAME, sub.subName);
} }
public void testInstanceCreatorReturnsSubTypeForField() { public void testInstanceCreatorReturnsSubTypeForField() {
Gson gson = new GsonBuilder() Gson gson = new GsonBuilder()
.registerTypeAdapter(Base.class, new InstanceCreator<Base>() { .registerTypeAdapter(Base.class, new InstanceCreator<Base>() {