From b02a10773f9d0aab960f826d3bb72996f05352db Mon Sep 17 00:00:00 2001 From: Brian Cristante <33549821+brcrista@users.noreply.github.com> Date: Mon, 13 Sep 2021 05:52:18 -0400 Subject: [PATCH] Create check-dist.yml (#212) --- .github/workflows/build.yml | 5 +-- .github/workflows/check-dist.yml | 51 +++++++++++++++++++++++++ .github/workflows/licensed.yml | 10 +++-- __tests__/verify-no-unstaged-changes.sh | 17 --------- 4 files changed, 59 insertions(+), 24 deletions(-) create mode 100644 .github/workflows/check-dist.yml delete mode 100644 __tests__/verify-no-unstaged-changes.sh diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9eb0e32..0078cbc 100755 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,7 +27,4 @@ jobs: - run: npm ci - run: npm run build - run: npm run format-check - - run: npm test - - name: Verify no unstaged changes - if: runner.os != 'windows' - run: bash __tests__/verify-no-unstaged-changes.sh + - run: npm test \ No newline at end of file diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml new file mode 100644 index 0000000..f03f47c --- /dev/null +++ b/.github/workflows/check-dist.yml @@ -0,0 +1,51 @@ +# `dist/index.js` is a special file in Actions. +# When you reference an action with `uses:` in a workflow, +# `index.js` is the code that will run. +# For our project, we generate this file through a build process from other source files. +# We need to make sure the checked-in `index.js` actually matches what we expect it to be. +name: Check dist/ + +on: + push: + branches: + - main + paths-ignore: + - '**.md' + pull_request: + paths-ignore: + - '**.md' + workflow_dispatch: + +jobs: + check-dist: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + + - name: Set Node.js 12.x + uses: actions/setup-node@v1 + with: + node-version: 12.x + + - name: Install dependencies + run: npm ci + + - name: Rebuild the dist/ directory + run: npm run build + + - name: Compare the expected and actual dist/ directories + run: | + if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then + echo "Detected uncommitted changes after build. See status below:" + git diff + exit 1 + fi + id: diff + + # If index.js was different than expected, upload the expected version as an artifact + - uses: actions/upload-artifact@v2 + if: ${{ failure() && steps.diff.conclusion == 'failure' }} + with: + name: dist + path: dist/ diff --git a/.github/workflows/licensed.yml b/.github/workflows/licensed.yml index ae62613..4c1dfe5 100644 --- a/.github/workflows/licensed.yml +++ b/.github/workflows/licensed.yml @@ -1,8 +1,12 @@ name: Licensed on: - push: {branches: main} - pull_request: {branches: main} + push: + branches: + - main + pull_request: + branches: + - main jobs: test: @@ -17,4 +21,4 @@ jobs: curl -Lfs -o licensed.tar.gz https://github.com/github/licensed/releases/download/2.12.2/licensed-2.12.2-linux-x64.tar.gz sudo tar -xzf licensed.tar.gz sudo mv licensed /usr/local/bin/licensed - - run: licensed status \ No newline at end of file + - run: licensed status diff --git a/__tests__/verify-no-unstaged-changes.sh b/__tests__/verify-no-unstaged-changes.sh deleted file mode 100644 index c99e226..0000000 --- a/__tests__/verify-no-unstaged-changes.sh +++ /dev/null @@ -1,17 +0,0 @@ -#!/bin/bash - -if [[ "$(git status --porcelain)" != "" ]]; then - echo ---------------------------------------- - echo git status - echo ---------------------------------------- - git status - echo ---------------------------------------- - echo git diff - echo ---------------------------------------- - git diff - echo ---------------------------------------- - echo Troubleshooting - echo ---------------------------------------- - echo "::error::Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run pre-checkin" - exit 1 -fi \ No newline at end of file