From d19e9fe0af6d335948547416e9685498405a8a9d Mon Sep 17 00:00:00 2001
From: Marcono1234 <Marcono1234@users.noreply.github.com>
Date: Wed, 16 Feb 2022 21:51:08 +0100
Subject: [PATCH] Improve Maven build and GitHub Maven workflow (#2079)

* Fix consecutive Maven builds failing without performing `clean`

By default moditect-maven-plugin refuses to overwrite the JAR file it
generated in a previous run.

* Make GitHub Maven build workflow detect Javadoc issues
---
 .github/workflows/build.yml | 3 ++-
 gson/pom.xml                | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 688ecff1..0008892e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,4 +15,5 @@ jobs:
           java-version: '11'
           cache: 'maven'
       - name: Build with Maven
-        run: mvn --batch-mode --update-snapshots verify
+        # This also runs javadoc:javadoc to detect any issues with the Javadoc
+        run: mvn --batch-mode --update-snapshots verify javadoc:javadoc
diff --git a/gson/pom.xml b/gson/pom.xml
index 64d68853..925d1559 100644
--- a/gson/pom.xml
+++ b/gson/pom.xml
@@ -86,6 +86,8 @@
               <module>
                 <moduleInfoFile>${project.build.sourceDirectory}/module-info.java</moduleInfoFile>
               </module>
+              <!-- Overwrite the previously generated JAR file, if any -->
+              <overwriteExistingFiles>true</overwriteExistingFiles>
             </configuration>
           </execution>
         </executions>