From cebda2b11921bf4f8adf5f36adfaa462b4cd1e1a Mon Sep 17 00:00:00 2001 From: Inderjeet Singh Date: Tue, 27 Sep 2011 15:38:02 +0000 Subject: [PATCH] Fixed MapTest.testInterfaceTypeMapWithSerializer. This test for relying on JsonElement.toString() to have same behavior as gson.toJson(JsonElement). However, gson.toJson() skips nulls by default whereas JsonElement.toString() does not. --- .../test/java/com/google/gson/functional/MapTest.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/gson/src/test/java/com/google/gson/functional/MapTest.java b/gson/src/test/java/com/google/gson/functional/MapTest.java index 10b9a9b5..309615ad 100755 --- a/gson/src/test/java/com/google/gson/functional/MapTest.java +++ b/gson/src/test/java/com/google/gson/functional/MapTest.java @@ -396,14 +396,15 @@ public class MapTest extends TestCase { Gson tempGson = new Gson(); String subTypeJson = tempGson.toJson(subType); - final JsonElement baseTypeJson = tempGson.toJsonTree(subType, TestTypes.Base.class); - String expected = "{\"bases\":{\"Test\":" + baseTypeJson.toString() + "}," + final JsonElement baseTypeJsonElement = tempGson.toJsonTree(subType, TestTypes.Base.class); + String baseTypeJson = tempGson.toJson(baseTypeJsonElement); + String expected = "{\"bases\":{\"Test\":" + baseTypeJson + "}," + "\"subs\":{\"Test\":" + subTypeJson + "}}"; JsonSerializer baseTypeAdapter = new JsonSerializer() { public JsonElement serialize(TestTypes.Base src, Type typeOfSrc, JsonSerializationContext context) { - return baseTypeJson; + return baseTypeJsonElement; } }; @@ -441,11 +442,11 @@ public class MapTest extends TestCase { private final Map bases = new HashMap(); private final Map subs = new HashMap(); - public final void addBase(final String name, final TestTypes.Base value) { + public final void addBase(String name, TestTypes.Base value) { bases.put(name, value); } - public final void addSub(final String name, final TestTypes.Sub value) { + public final void addSub(String name, TestTypes.Sub value) { subs.put(name, value); } }