From 9c894c748550690ee4b5b4f982a350da6a08e5f9 Mon Sep 17 00:00:00 2001 From: Inderjeet Singh Date: Thu, 31 Mar 2011 18:57:55 +0000 Subject: [PATCH] switched from accessing field to an accessor method for access in tests. Strangely, this fixes the broken tests in the continuous build. --- .../com/google/gson/DefaultConstructorAllocator.java | 10 +++++++--- .../google/gson/DefaultConstructorAllocatorTest.java | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/gson/src/main/java/com/google/gson/DefaultConstructorAllocator.java b/gson/src/main/java/com/google/gson/DefaultConstructorAllocator.java index d4163ba8..b8df6407 100644 --- a/gson/src/main/java/com/google/gson/DefaultConstructorAllocator.java +++ b/gson/src/main/java/com/google/gson/DefaultConstructorAllocator.java @@ -24,11 +24,10 @@ import java.lang.reflect.Constructor; * * @author Joel Leitch */ -class DefaultConstructorAllocator { +final class DefaultConstructorAllocator { private static final Constructor NULL_CONSTRUCTOR = createNullConstructor(); - // Package private for testing purposes. - final Cache, Constructor> constructorCache; + private final Cache, Constructor> constructorCache; public DefaultConstructorAllocator() { this(200); @@ -38,6 +37,11 @@ class DefaultConstructorAllocator { constructorCache = new LruCache, Constructor>(cacheSize); } + // for testing purpose + final Cache, Constructor> getConstructorCache() { + return constructorCache; + } + private static final Constructor createNullConstructor() { try { return getNoArgsConstructor(Null.class); diff --git a/gson/src/test/java/com/google/gson/DefaultConstructorAllocatorTest.java b/gson/src/test/java/com/google/gson/DefaultConstructorAllocatorTest.java index 0a30ef25..820e79dc 100644 --- a/gson/src/test/java/com/google/gson/DefaultConstructorAllocatorTest.java +++ b/gson/src/test/java/com/google/gson/DefaultConstructorAllocatorTest.java @@ -54,7 +54,7 @@ public class DefaultConstructorAllocatorTest extends TestCase { } private void assertInCache(Class clazz) { - assertNotNull(allocator.constructorCache.getElement(clazz)); + assertNotNull(allocator.getConstructorCache().getElement(clazz)); } private static class NoDefaultConstructor {