From 5253ddbde0a366bb7667d94b56b0c940e465437d Mon Sep 17 00:00:00 2001
From: Marcono1234 <Marcono1234@users.noreply.github.com>
Date: Wed, 28 Sep 2022 08:02:15 +0200
Subject: [PATCH] Follow-up for record test build changes (#2207)

---
 gson/pom.xml                                                 | 1 -
 gson/src/main/java/com/google/gson/TypeAdapter.java          | 3 +++
 .../java/com/google/gson/functional/Java17RecordTest.java    | 2 +-
 .../com/google/gson/functional/ReflectionAccessTest.java     | 2 +-
 pom.xml                                                      | 5 +++--
 5 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/gson/pom.xml b/gson/pom.xml
index e53251e9..3861a935 100644
--- a/gson/pom.xml
+++ b/gson/pom.xml
@@ -247,7 +247,6 @@
       <properties>
         <maven.compiler.testRelease>17</maven.compiler.testRelease>
         <excludeTestCompilation></excludeTestCompilation>
-        <extraLintSuppressions>,-exports,-missing-explicit-ctor,-removal</extraLintSuppressions>
       </properties>
     </profile>
   </profiles>
diff --git a/gson/src/main/java/com/google/gson/TypeAdapter.java b/gson/src/main/java/com/google/gson/TypeAdapter.java
index 5685cadb..98e1668a 100644
--- a/gson/src/main/java/com/google/gson/TypeAdapter.java
+++ b/gson/src/main/java/com/google/gson/TypeAdapter.java
@@ -118,6 +118,9 @@ import java.io.Writer;
 //
 public abstract class TypeAdapter<T> {
 
+  public TypeAdapter() {
+  }
+
   /**
    * Writes one JSON value (an array, object, string, number, boolean or null)
    * for {@code value}.
diff --git a/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java b/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java
index 345da29e..95166d82 100644
--- a/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java
+++ b/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java
@@ -27,7 +27,7 @@ import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 
 @RunWith(JUnit4.class)
-@Ignore
+@Ignore // Disabled until record support is added
 public final class Java17RecordTest {
   private final Gson gson = new Gson();
 
diff --git a/gson/src/test/java/com/google/gson/functional/ReflectionAccessTest.java b/gson/src/test/java/com/google/gson/functional/ReflectionAccessTest.java
index 71e293e8..cdf56852 100644
--- a/gson/src/test/java/com/google/gson/functional/ReflectionAccessTest.java
+++ b/gson/src/test/java/com/google/gson/functional/ReflectionAccessTest.java
@@ -37,7 +37,7 @@ public class ReflectionAccessTest {
   }
 
   @Test
-  @SuppressWarnings("removal") // java.lang.SecurityManager
+  @SuppressWarnings("removal") // java.lang.SecurityManager deprecation in Java 17
   public void testRestrictiveSecurityManager() throws Exception {
     // Must use separate class loader, otherwise permission is not checked, see Class.getDeclaredFields()
     Class<?> clazz = loadClassWithDifferentClassLoader(ClassWithPrivateMembers.class);
diff --git a/pom.xml b/pom.xml
index ecb68860..b7327676 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,7 +22,6 @@
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <maven.compiler.release>7</maven.compiler.release>
-    <extraLintSuppressions></extraLintSuppressions>
   </properties>
 
   <scm>
@@ -77,7 +76,7 @@
             <compilerArgs>
               <!-- Enable all warnings, except for ones which cause issues when building with newer JDKs, see also
                 https://docs.oracle.com/en/java/javase/11/tools/javac.html -->
-              <compilerArg>-Xlint:all,-options${extraLintSuppressions}</compilerArg>
+              <compilerArg>-Xlint:all,-options</compilerArg>
             </compilerArgs>
             <jdkToolchain>
               <version>[11,)</version>
@@ -92,6 +91,8 @@
             <jdkToolchain>
               <version>[11,)</version>
             </jdkToolchain>
+            <!-- Specify newer JDK as target to allow linking to newer Java API, and to generate
+              module overview in Javadoc for Gson's module descriptor -->
             <release>11</release>
             <!-- Exclude `missing` group because some tags have been omitted when they are redundant -->
             <doclint>all,-missing</doclint>