From 4c685b21a83b754abdf129f2efe9b9129aab8768 Mon Sep 17 00:00:00 2001 From: joel-leitch Date: Mon, 21 May 2018 20:04:22 -0700 Subject: [PATCH] Private constructor (#1324) * Adding private constructors on Util classes * Remove obsolete step --- ReleaseProcess.md | 1 - .../com/google/gson/internal/GsonBuildConfig.java | 2 ++ gson/src/main/java/com/google/gson/internal/JavaVersion.java | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ReleaseProcess.md b/ReleaseProcess.md index 4b7fbb2d..bb2719cd 100644 --- a/ReleaseProcess.md +++ b/ReleaseProcess.md @@ -3,7 +3,6 @@ The following is a step-by-step procedure for releasing a new version of Google-Gson. 1. Go through all open bugs and identify which will be fixed in this release. Mark all others with an appropriate release tag. Identify duplicates, and close the bugs that will never be fixed. Fix all bugs for the release, and mark them fixed. -1. (obsolete step) Edit [`pom.xml`](pom.xml) and update the versions listed for Export-Package to the target version. Also add any new Java packages that have been introduced in Gson. 1. Ensure all changelists are code-reviewed and have +1 1. `cd gson` to the parent directory; ensure there are no open files and all changes are committed. 1. Run `mvn release:clean` diff --git a/gson/src/main/java-templates/com/google/gson/internal/GsonBuildConfig.java b/gson/src/main/java-templates/com/google/gson/internal/GsonBuildConfig.java index 73c61546..a94c96b8 100644 --- a/gson/src/main/java-templates/com/google/gson/internal/GsonBuildConfig.java +++ b/gson/src/main/java-templates/com/google/gson/internal/GsonBuildConfig.java @@ -27,4 +27,6 @@ public final class GsonBuildConfig { /** This field is automatically populated by Maven when a build is triggered */ public static final String VERSION = "${project.version}"; + + private GsonBuildConfig() { } } diff --git a/gson/src/main/java/com/google/gson/internal/JavaVersion.java b/gson/src/main/java/com/google/gson/internal/JavaVersion.java index 3887e7da..fab1b7c2 100644 --- a/gson/src/main/java/com/google/gson/internal/JavaVersion.java +++ b/gson/src/main/java/com/google/gson/internal/JavaVersion.java @@ -87,4 +87,6 @@ public final class JavaVersion { public static boolean isJava9OrLater() { return majorJavaVersion >= 9; } + + private JavaVersion() { } }