Johannes/S-dom
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

fix: since loggedIn is determined by state we control, cache the value to avoid expensive lookups

Browse Source
This commit is contained in:
Johannes Frohnmeyer 2024-05-17 09:11:03 +02:00
parent d3ccb51df4
commit ac8e2f5443
Signed by: Johannes
GPG Key ID: E76429612C2929F4
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/kotlin/io/gitlab/jfronny/sdom/SDCredentials.kt
View File

@ -16,11 +16,13 @@ object SDCredentials {
.run { this?.userName to this?.getPasswordAsString() } .run { this?.userName to this?.getPasswordAsString() }
set(value) { set(value) {
PasswordSafe.instance[createCredentialAttributes("httpAuth")] = Credentials(value.first, value.second) PasswordSafe.instance[createCredentialAttributes("httpAuth")] = Credentials(value.first, value.second)
loggedIn = value.first != null && value.second != null
} }
fun logOut() { fun logOut() {
PasswordSafe.instance[createCredentialAttributes("httpAuth")] = null PasswordSafe.instance[createCredentialAttributes("httpAuth")] = null
PasswordSafe.instance[createCredentialAttributes("teamId")] = null PasswordSafe.instance[createCredentialAttributes("teamId")] = null
loggedIn = false
} }
var url: String var url: String
@ -34,4 +36,7 @@ object SDCredentials {
set(value) { set(value) {
PasswordSafe.instance[createCredentialAttributes("teamId")] = Credentials(value) PasswordSafe.instance[createCredentialAttributes("teamId")] = Credentials(value)
} }
var loggedIn: Boolean = credentials.first != null && credentials.second != null
private set
} }

3
src/main/kotlin/io/gitlab/jfronny/sdom/SDom.kt
View File

@ -291,8 +291,7 @@ object SDom {
baos.toByteArray() baos.toByteArray()
})) }))
val loggedIn: Boolean val loggedIn: Boolean get() = SDCredentials.loggedIn
get() = SDCredentials.credentials.first != null && SDCredentials.credentials.second != null
init { init {
if (loggedIn) { if (loggedIn) {