JfMods/async-pack-scan
JfMods
/
async-pack-scan
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Causes every resource pack/mod library file to be shown in resource pack screen #1

Helpdesk
Closed
opened 2024-03-14 21:11:38 +01:00 by Zorklis · 3 comments
Zorklis commented 2024-03-14 21:11:38 +01:00
Copy Link

Finally narrowed this problem to Async.
Not sure why it's a bug or a "feature" of this mod but it is.

I open resource pack screen everything is fine. I select a pack to selected tab and then press done, loading screen.. and every mod is now occupying the resource pack for no good reason. WHY

Finally narrowed this problem to Async. Not sure why it's a bug or a "feature" of this mod but it is. I open resource pack screen everything is fine. I select a pack to selected tab and then press done, loading screen.. and every mod is now occupying the resource pack for no good reason. WHY
javaw_excmGPr74A.png
365 KiB
javaw_excmGPr74A.png
Johannes commented 2024-03-15 12:12:35 +01:00
Owner
Copy Link

Thank you for reporting this.
It seems that the filtering done by fabric-resource-loader is applied in a method I overwrite to call my asynchronous implementation.
I have implemented a potential fix by manually filtering packs after it is finished.
Does this version fix the issue for you? If it does, I could create a release with it.

Thank you for reporting this. It seems that the filtering done by fabric-resource-loader is applied in a method I overwrite to call my asynchronous implementation. I have implemented a potential fix by manually filtering packs after it is finished. Does [this version](https://pages.frohnmeyer-wds.de/JfMods/async-pack-scan/artifacts/latest.jar) fix the issue for you? If it does, I could create a release with it.
Zorklis commented 2024-03-17 21:33:31 +01:00
Author
Copy Link

Tried it and no issues with the version you gave, looks good to me 👍

Tried it and no issues with the version you gave, looks good to me 👍
Johannes commented 2024-03-18 09:34:35 +01:00
Owner
Copy Link

I have published 0.2.3 with these changes.
Again, thanks for reporting the issue!

I have published 0.2.3 with these changes. Again, thanks for reporting the issue!
Comment
No Branch/Tag Specified
Branches Tags
master
0.2.4-beta
0.2.3-beta
0.2.2-beta
0.2.1-beta
b0.2.0
b0.1.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JfMods/async-pack-scan#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?