Compare commits

...

2 Commits

Author SHA1 Message Date
Johannes Frohnmeyer f82ded7e5d
perf: parallel translation
ci/woodpecker/push/jfmod Pipeline was successful Details
2023-10-05 16:46:41 +02:00
Johannes Frohnmeyer dfea11cafd
fix: use new default translater cache entries on existing translations 2023-10-05 15:53:29 +02:00
7 changed files with 116 additions and 38 deletions

View File

@ -10,6 +10,7 @@ public class Cfg {
@Entry public static String targetLanguage = "en";
@Entry public static ProgressMode renderProgress = ProgressMode.None;
@Entry public static boolean forceRegenerate = false;
@Entry public static boolean useDefaultCache = true;
static {
JFC_Cfg.ensureInitialized();

View File

@ -0,0 +1,25 @@
package io.gitlab.jfronny.translater;
import io.gitlab.jfronny.translater.mixin.MinecraftClientAccessor;
import net.minecraft.client.MinecraftClient;
import java.util.concurrent.atomic.AtomicBoolean;
public class RenderScheduler {
private final AtomicBoolean shouldRun = new AtomicBoolean(false);
public void scheduleRender() {
shouldRun.set(true);
if (MinecraftClient.getInstance().isOnThread()) performTask();
}
public void deschedule() {
shouldRun.set(false);
}
private void performTask() {
do {
((MinecraftClientAccessor) MinecraftClient.getInstance()).invokeRender(false);
} while (shouldRun.compareAndSet(true, false));
}
}

View File

@ -4,14 +4,19 @@ import io.gitlab.jfronny.libjf.config.api.v2.ConfigHolder;
import io.gitlab.jfronny.translater.Cfg;
import io.gitlab.jfronny.translater.Translater;
import net.fabricmc.loader.api.FabricLoader;
import org.jetbrains.annotations.Nullable;
import java.io.*;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collection;
import java.util.Properties;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.stream.Stream;
public class CachingTransformer implements Transformer {
private static final Path CACHE_FILE = FabricLoader.getInstance().getConfigDir().resolve(Translater.MOD_ID + ".cache");
private final @Nullable Properties defaultCache;
private final Properties cache = new Properties();
private final Transformer transformer;
@ -21,6 +26,7 @@ public class CachingTransformer implements Transformer {
return null;
//Transform and cache if not present
if (!cache.containsKey(str)) {
if (defaultCache != null && defaultCache.containsKey(str)) return (String) defaultCache.get(str);
String transformed = transformer.transform(str);
if (transformed == null) {
// The transformer failed
@ -33,6 +39,30 @@ public class CachingTransformer implements Transformer {
return (String) cache.get(str);
}
@Override
public void transformMultiple(Stream<? extends String> strings, ResultConsumer results) {
AtomicBoolean bl = new AtomicBoolean(false);
transformer.transformMultiple(strings.filter(s -> {
String translation = (String) cache.get(s);
if (translation != null) {
results.accept(s, translation);
return false;
}
if (defaultCache != null) {
translation = (String) defaultCache.get(s);
if (translation != null) {
results.accept(s, translation);
return false;
}
}
return true;
}), (str, translation) -> {
cache.put(str, translation);
bl.set(true);
});
if (bl.get()) save();
}
public CachingTransformer(Transformer baseTransformer) {
transformer = baseTransformer;
if (Cfg.forceRegenerate) {
@ -47,28 +77,27 @@ public class CachingTransformer implements Transformer {
} catch (IOException e) {
Translater.LOGGER.error("Could not load translater cache", e);
}
} else {
//Save default cache if parameters are default
if (!Cfg.breakFully && Cfg.rounds == 5) {
Translater.LOGGER.info("Initializing default cache");
ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
InputStream inS = classLoader.getResourceAsStream("namecache.ini");
if (inS != null) {
try {
cache.load(inS);
inS.close();
save();
} catch (IOException e) {
Translater.LOGGER.error("Could not initialize default translater cache");
}
}
}
}
}
//Save default cache if parameters are default
if (!Cfg.breakFully && Cfg.rounds == 5 && "en".equals(Cfg.targetLanguage) && !Cfg.forceRegenerate) {
Translater.LOGGER.info("Initializing default cache");
ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
Properties p = new Properties();
try (InputStream inS = classLoader.getResourceAsStream("namecache.ini")) {
if (inS == null) p = null;
else p.load(inS);
} catch (IOException e) {
p = null;
Translater.LOGGER.error("Could not initialize default translater cache", e);
}
defaultCache = p;
} else defaultCache = null;
save();
}
private void save() {
if (cache.isEmpty()) return;
try (OutputStream outS = Files.newOutputStream(CACHE_FILE)) {
cache.store(outS, "---Lang---");
} catch (IOException e) {

View File

@ -1,5 +1,13 @@
package io.gitlab.jfronny.translater.transformer;
import java.util.stream.Stream;
public interface Transformer {
String transform(String str);
void transformMultiple(Stream<? extends String> strings, ResultConsumer results);
@FunctionalInterface
interface ResultConsumer {
void accept(String str, String translation);
}
}

View File

@ -1,5 +1,6 @@
package io.gitlab.jfronny.translater.transformer;
import io.gitlab.jfronny.translater.RenderScheduler;
import io.gitlab.jfronny.translater.Translater;
import io.gitlab.jfronny.translater.mixin.MinecraftClientAccessor;
import net.minecraft.client.MinecraftClient;
@ -7,12 +8,15 @@ import net.minecraft.client.MinecraftClient;
import java.util.Collection;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;
public class TransformingMap implements Map<String, String> {
private final Transformer transformer;
private final RenderScheduler renderScheduler = new RenderScheduler();
private Map<String, String> backer = null;
public boolean initializing = false;
private String initProgress = null;
private AtomicInteger initProgress = null;
private int maxProgress = 0;
public TransformingMap(Transformer t) {
transformer = t;
@ -23,24 +27,26 @@ public class TransformingMap implements Map<String, String> {
this.backer = backer;
Collection<String> strings = backer.values();
initializing = true;
final int max = strings.size();
int i = 0;
for (String value : strings) {
initProgress = "Transforming " + i++ + "/" + max;
if (Translater.progressLogsEnabled())
Translater.LOGGER.info(initProgress);
if (Translater.progressUIEnabled() && i % 10 == 0)
((MinecraftClientAccessor) MinecraftClient.getInstance()).invokeRender(false);
initProgress = null;
transformer.transform(value);
}
generateTranslations(strings);
initializing = false;
}
}
private void generateTranslations(Collection<? extends String> strings) {
maxProgress = strings.size();
initProgress = new AtomicInteger();
transformer.transformMultiple(strings.parallelStream(), (str, translation) -> {
int i = initProgress.incrementAndGet();
if (Translater.progressLogsEnabled()) Translater.LOGGER.info(getInitProgress());
if (Translater.progressUIEnabled() && i % 10 == 0) renderScheduler.scheduleRender();
});
renderScheduler.deschedule();
initProgress = null;
}
public String getInitProgress() {
if (initProgress == null || !initializing) throw new IllegalStateException("Tried to get init progress while not initializing");
return initProgress;
return "Transforming " + initProgress.get() + "/" + maxProgress;
}
@Override
@ -65,8 +71,7 @@ public class TransformingMap implements Map<String, String> {
@Override
public String get(Object o) {
if (o instanceof String && ((String)o).startsWith("translater."))
return backer.get(o);
if (o instanceof String s && s.startsWith("translater.")) return backer.get(s);
return transformer.transform(backer.get(o));
}
@ -83,9 +88,7 @@ public class TransformingMap implements Map<String, String> {
@Override
public void putAll(Map<? extends String, ? extends String> map) {
for (String value : map.values()) {
transformer.transform(value);
}
generateTranslations(map.values());
backer.putAll(map);
}
@ -101,11 +104,11 @@ public class TransformingMap implements Map<String, String> {
@Override
public Collection<String> values() {
return backer.values();
return backer.values(); // This does not support updates, but I don't care
}
@Override
public Set<Entry<String, String>> entrySet() {
return backer.entrySet();
return backer.entrySet(); // This does not support updates, but I don't care
}
}

View File

@ -7,10 +7,10 @@ import io.gitlab.jfronny.translater.Cfg;
import io.gitlab.jfronny.translater.Translater;
import org.apache.commons.lang3.StringUtils;
import java.util.List;
import java.util.Random;
import java.util.*;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Stream;
public class TranslatingTransformer<T extends Language> implements Transformer {
public TranslatingTransformer(TranslateService<T> ts) {
@ -77,6 +77,16 @@ public class TranslatingTransformer<T extends Language> implements Transformer {
}
}
@Override
public void transformMultiple(Stream<? extends String> strings, ResultConsumer results) {
strings.flatMap(s -> {
String translation = transform(s);
return translation == null ? Stream.empty() : Stream.of(new Translation(s, translation));
}).forEach(t -> results.accept(t.from, t.to));
}
private record Translation(String from, String to) {}
private String translateMultiple(String str) throws TranslateException {
Matcher m = SURROUNDING_SPACE_PATTERN.matcher(str);
if (!m.find()) {

View File

@ -10,6 +10,8 @@
"translater.jfconfig.renderProgress.tooltip": "Significantly slows down the loading time but gives a visual of the progress. Values: Full, Console, None",
"translater.jfconfig.forceRegenerate": "Force Regenerate",
"translater.jfconfig.forceRegenerate.tooltip": "Use this if something is broken. This initiates the regeneration of the cache",
"translater.jfconfig.useDefaultCache": "Use default Cache",
"translater.jfconfig.useDefaultCache.tooltip": "Use pre-generated translations shipped with the mod if the config permits to save time",
"translater.jfconfig.enum.ProgressMode.Full": "Full",
"translater.jfconfig.enum.ProgressMode.Gui": "Gui",
"translater.jfconfig.enum.ProgressMode.Console": "Console",