condition fail throws ERROR in log #6

Helpdesk

Minecrafthyr · 2023-12-31T23:04:11+01:00

Minecrafthyr commented

2023-12-31 23:04:11 +01:00

If a respackopts condition fail, it will throw an error in the log, causes lag and isn't good for debug. It should be throw a warning in the log.
For example, the attached log file has about 2000 lines are thrown by respackopts in a few clicks.

If a respackopts condition fail, it will throw an error in the log, causes lag and isn't good for debug. It should be throw a warning in the log. For example, the attached log file has about 2000 lines are thrown by respackopts in a few clicks.

2024-01-01-1.log.gz

1.8 MiB

Johannes commented

2024-01-01 01:17:43 +01:00

There is no fundamental difference between errors and warnings, for all intents and purposes the only thing that changes is whether "warning" or "error" is inserted before the message, so printing a warning instead would change pretty much nothing about the performance of the code.
Additionally, I believe the circumstance of an incorrect pack more closely matches the definition of an error than that of a warning as per the SLF4J docs, which is why I chose that level in the first place. Marking these issues as a warning instead merely downplays their severity, which is counterproductive.
If I have misunderstood your argument (which is almost certain), please clarify what you mean, possibly by providing an example.

There is no fundamental difference between errors and warnings, for all intents and purposes the only thing that changes is whether "warning" or "error" is inserted before the message, so printing a warning instead would change pretty much nothing about the performance of the code. Additionally, I believe the circumstance of an incorrect pack more closely matches the definition of an error than that of a warning as per the SLF4J docs, which is why I chose that level in the first place. Marking these issues as a warning instead merely downplays their severity, which is counterproductive. If I have misunderstood your argument (which is almost certain), please clarify what you mean, possibly by providing an example.

Johannes commented

2024-03-02 16:19:39 +01:00

I'm closing this since you didn't respond.
If you have new information or a new idea on how to word your issue to help me understand it, you can reopen it or create a new one.

I'm closing this since you didn't respond. If you have new information or a new idea on how to word your issue to help me understand it, you can reopen it or create a new one.

Johannes closed this issue

2024-03-02 16:19:39 +01:00

Comment

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JfMods/Respackopts#6