Multiple options for menu panorama completely breaks it in 1.20.5 #10
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
So in a pack I have multiple menu panoramas. They are set up to be able to be changed through an enum option. It worked completely fine in 1.20.4, but in version 4.8.0 for 1.20.5 it doesn't apply the correct textures for every panorama image. It seems to be almost completely random, mixing all provided panorama images at once.
Could you send me a pack that allows me to reproduce the issue?
Sure. I've removed some of the files from the pack that are unrelated to the issue, so just ignore the unused rpo options. To reproduce the issue, load the pack in version 1.20.5 with rpo installed and try to change the Resourcepack option for menu panorama under the GUI tab. Doing the same while using rpo on 1.20.4 and the pack will work as intended. The same pack in vanilla 1.20.5 will at least display the main panorama in the pack correctly.
I have downloaded the pack you provided, but I was unable to reproduce the issue you described.
I have loaded the pack without a preexisting config, changed settings in the config screen and started with a non-default config.
None of these caused the issue you described.
One guess as to what might cause this is an incompatibility with another mod.
Could you try reproducing the issue with only LibJF, Respackopts and Fabric API?
If the issue does not happen there, one guess I have is optimization mods like dash loader, which might interfere with the initialization process.
If the issue happens even with only those, step-by-step instructions that allow me to reproduce it would likely be helpful.
Sorry for not being more helpful here, especially after taking so long, but without reproducing it I can't fix it.
I also thought that may be the case, so I did test it quickly with only LibJF, Respackopts, and Fabric API before submitting this issue. The issue would happen after switching the resourcepack option for the menu panorama. But I tried again today with only those mods, and I noticed that the issue doesn't persist after a quick relog, and the selected panorama is correctly applied. Strangely enough it seems to be sodium that causes the issue. I tried running just repackopts, libjf, fabric API, and sodium. When I launch with this mod configuration, the game will immediately display a toast saying "Resource Reload Failed". This toast will display 90% of the time I load any rpo enabled pack. If it doesn't display the toast, some textures will be incorrectly chosen in a way that doesn't correspond to the resourcepack options selected. It does this more frequently when changing packs from the main menu than from in a world. I'm not sure if sodium compatibility is something you are supporting, but it is still strange because respackopts worked completely fine with sodium in 1.20.4.
Sodium is supported.
Still, I cannot reproduce the issue you describe, nor do I recall ever coming across something like it in testing.
I can only assume that something else is interfering with your install in a very peculiar way, since resources being loaded in three different configurations is not something that should even be possible.
I have made some changes that might uncover something in this build, so if you use it when running the game with
debugLogsenabled in the respackopts config and upload the log here, I might be able to find out something.Though if that doesn't work, I guess I'll have to close this until I come across a configuration that allows me to reproduce this.
Sorry if that is disappointing, but I cannot fix an issue I don't understand.
I cleared out some of the junk from the resourcepack I sent here. When I did some testing with that new pack I had the issue happen when I would use different installation directories. I think it might have been something with rpo finding packs with the same rpo id in different directories under .minecraft. The issue is no longer happening with the new example resourcepack since I have changed its rpo id. I'm no longer having the issue, both with and without sodium. But I have still uploaded the modified test resourcepack and some logs with debugLogs enabled in case you still wanted to try and figure out what happened. I think rpo was loading from an incorrect directory. I have multiple Minecraft installations with different game directories all located within .minecraft. Some of these had old versions of unzipped resourcepacks I was working on with the same rpo id. Anyways, thanks for your help.
Thanks for the logs! They seem to point to a possibly related issue in jfCommons which I have now fixed, and have made a LibJF release for.
With your description, this sounds like it was caused by duplicate IDs, which technically should work, but I have added some new warnings and workarounds in the latest version to help alleviate future issues.
Again, thanks for reporting!