Resclone doesn't download ressourcepacks correctly #1
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I don't know if it's a general issue or specific to my ressourcepack (it would be strange tho)
I tried with the GitHub and file fetcher, and the checksum is invalid compared to the source, when checking the files inside the cache folder. It seems that the downloaded ressourcepacks are missing some random mcmeta files for my resourcepack (for example the command block mcmeta files).
Since I tried with two different servers for the file fetcher and GitHub, I'm pretty sure that the problem is linked to resclone in some way, it's not a failure of the servers which serve the files. Nothing worthwhile is shown in the logs of the client, resclone tells inside the logs that the download was done successfully.
Of course, I confirmed that the problem still exists without any other mods.
Here is the ressourcepack, on github and on my server :
https://vinderland.fr/resourcepacks/rift.zip
https://github.com/mortebrume/testrift
Thank you !
Thanks for reporting this.
This seems to be caused by an intentional feature that processes downloaded resource packs to attempt to remove duplicate/unnecessary files (like ones unchanged from vanilla), incorrectly placed roots and empty directories.
I have added an option to log those modifications to hopefully better inform the user about them.
I could also add an option to disable (some of) them, but doing so carries the risk of actually breaking packs from some sources (such as anything downloaded from GitHub), which is why it doesn't exist yet.
If you think I should add it, I can do so, though.
Thank you, I tested with the additional logging and I can confirm that it's the issue.
It seems that with the pack that we are using (based on excalibur) if the mcmetas are unchanged from vanilla. But there are visuals problems, because it seems that minecraft doesn't replace the mcmeta, perhaps because the texture is modified. I can confirm that the problem exists even with all the mods disabled, the processed resourcepack is just invalid.
Perhaps the assumption is false, perhaps it's only a specific issue with the texturepack, I don't know. It would be nice to have an option to disable processing of "unchanged from vanilla files". My usecase is to keep updated a specific resourcepack for a modpack distributed to users in a roleplaying server, so even without github as a fetcher it's not a issue for us.
Logs
I have added an option to disable the additional processors.
The archive is still opened as mutable, so checksum correctness is still not guaranteed, but it not being correct (if the root path processor is not applied) would now be a bug.
Could you try it? If it works for you, I'll create a new version with the changes made here.
I can confirm that everything works for me with the additional processing disabled, the ckecksum is also correct !
Thank you for the quick fix !
Version 1.12.0 contains the new changes and has been published.
Again, thanks for reporting.