Freshly generated libjf-translate-v1 config showing error in game log #3

Closed
opened 2024-03-11 00:19:34 +01:00 by BlueJayofEvil · 2 comments

Minecraft: 1.20.4
Fabric Loader: 0.15.7
LibJF: 3.14.2
Console log: https://mclo.gs/Bl9v071

LibJF seems to be generating an incorrect line in the libjf-translate-v1 config file.
I use Prism launcher and created a fresh minimal instance to confirm this. The game log indicates shows this message upon loading:

[main/ERROR]: Could not read config for libjf-translate-v1
java.lang.IllegalStateException: Expected a name but was NULL at line 4 column 27 (char '
') path $.libreTranslateHost
See https://github.com/google/gson/blob/main/Troubleshooting.md#adapter-not-null-safe
	at io.gitlab.jfronny.gson.stream.JsonReader.unexpectedTokenError(JsonReader.java:1769) ~[libjf-base-3.14.2-1dfc50b79150e6e9.jar:?]
	at io.gitlab.jfronny.gson.stream.JsonReader.nextName(JsonReader.java:889) ~[libjf-base-3.14.2-1dfc50b79150e6e9.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DefaultConfigIO.runActions(DefaultConfigIO.java:47) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DefaultConfigIO.lambda$loader$0(DefaultConfigIO.java:23) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at java.util.Optional.ifPresent(Optional.java:178) ~[?:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DefaultConfigIO.lambda$loader$1(DefaultConfigIO.java:18) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DslConfigInstance.load(DslConfigInstance.java:38) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.ConfigBuilderImpl.build(ConfigBuilderImpl.java:66) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.ConfigBuilderImpl.build(ConfigBuilderImpl.java:10) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl.config(DSLImpl.java:11) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl.register(DSLImpl.java:21) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl.register(DSLImpl.java:16) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl$Defaulted.register(DSLImpl.java:40) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at io.gitlab.jfronny.libjf.translate.impl.TranslateConfig.<clinit>(TranslateConfig.java:26) ~[libjf-translate-v1-3.14.2-4da6c8277ca20502.jar:?]
	at java.lang.Class.forName0(Native Method) ~[?:?]
	at java.lang.Class.forName(Class.java:534) ~[?:?]
	at java.lang.Class.forName(Class.java:513) ~[?:?]
	at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50) ~[fabric-loader-0.15.7.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:117) ~[fabric-loader-0.15.7.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53) ~[fabric-loader-0.15.7.jar:?]
	at io.gitlab.jfronny.libjf.config.impl.entrypoint.JfConfigSafe.onPreLaunch(JfConfigSafe.java:24) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?]
	at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:384) ~[fabric-loader-0.15.7.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:160) ~[fabric-loader-0.15.7.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) ~[fabric-loader-0.15.7.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.15.7.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) ~[NewLaunch.jar:?]

Looking at the config file, the line causing the issue is libreTranslateHost: null
If I change null to Noop the error stops appearing in my logs.
This seems to be benign (no gameplay issues or crashes occur from this) but I thought I'd report it since it seems unintentional.

Minecraft: 1.20.4 Fabric Loader: 0.15.7 LibJF: 3.14.2 Console log: https://mclo.gs/Bl9v071 LibJF seems to be generating an incorrect line in the libjf-translate-v1 config file. I use Prism launcher and created a fresh minimal instance to confirm this. The game log indicates shows this message upon loading: ``` [main/ERROR]: Could not read config for libjf-translate-v1 java.lang.IllegalStateException: Expected a name but was NULL at line 4 column 27 (char ' ') path $.libreTranslateHost See https://github.com/google/gson/blob/main/Troubleshooting.md#adapter-not-null-safe at io.gitlab.jfronny.gson.stream.JsonReader.unexpectedTokenError(JsonReader.java:1769) ~[libjf-base-3.14.2-1dfc50b79150e6e9.jar:?] at io.gitlab.jfronny.gson.stream.JsonReader.nextName(JsonReader.java:889) ~[libjf-base-3.14.2-1dfc50b79150e6e9.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DefaultConfigIO.runActions(DefaultConfigIO.java:47) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DefaultConfigIO.lambda$loader$0(DefaultConfigIO.java:23) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at java.util.Optional.ifPresent(Optional.java:178) ~[?:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DefaultConfigIO.lambda$loader$1(DefaultConfigIO.java:18) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DslConfigInstance.load(DslConfigInstance.java:38) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.ConfigBuilderImpl.build(ConfigBuilderImpl.java:66) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.ConfigBuilderImpl.build(ConfigBuilderImpl.java:10) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl.config(DSLImpl.java:11) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl.register(DSLImpl.java:21) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl.register(DSLImpl.java:16) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.config.impl.dsl.DSLImpl$Defaulted.register(DSLImpl.java:40) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at io.gitlab.jfronny.libjf.translate.impl.TranslateConfig.<clinit>(TranslateConfig.java:26) ~[libjf-translate-v1-3.14.2-4da6c8277ca20502.jar:?] at java.lang.Class.forName0(Native Method) ~[?:?] at java.lang.Class.forName(Class.java:534) ~[?:?] at java.lang.Class.forName(Class.java:513) ~[?:?] at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50) ~[fabric-loader-0.15.7.jar:?] at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:117) ~[fabric-loader-0.15.7.jar:?] at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53) ~[fabric-loader-0.15.7.jar:?] at io.gitlab.jfronny.libjf.config.impl.entrypoint.JfConfigSafe.onPreLaunch(JfConfigSafe.java:24) ~[libjf-config-core-v2-3.14.2-403fcb721f5c63ee.jar:?] at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:384) ~[fabric-loader-0.15.7.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:160) ~[fabric-loader-0.15.7.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) ~[fabric-loader-0.15.7.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.15.7.jar:?] at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) ~[NewLaunch.jar:?] at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) ~[NewLaunch.jar:?] at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) ~[NewLaunch.jar:?] ``` Looking at the config file, the line causing the issue is **libreTranslateHost: null** If I change **null** to **Noop** the error stops appearing in my logs. This seems to be benign (no gameplay issues or crashes occur from this) but I thought I'd report it since it seems unintentional.
Owner

That setting represents a URL that is intended to be null by default, so "Noop" might cause issues.
The log mentions character 27, while the line is 26 characters long, so the message indicates that the error occurs after it.
This does not occur in my testing using the default config.
Could you upload your config file?

That setting represents a URL that is intended to be null by default, so "Noop" might cause issues. The log mentions character 27, while the line is 26 characters long, so the message indicates that the error occurs after it. This does not occur in my testing using the default config. Could you upload your config file?
Owner

After further investigation, this seems to be an issue within config-core triggered by Windows using CRLF line endings.
I have released a potential fix in 3.14.3.

After further investigation, this seems to be an issue within config-core triggered by Windows using CRLF line endings. I have released a potential fix in 3.14.3.
Comment
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: JfMods/LibJF#3
No description provided.